Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: make enumerated attributes missing/invalid wording consistent #9947

Conversation

keithamus
Copy link
Contributor

@keithamus keithamus commented Nov 22, 2023

Per #9944 (review) & #9944 (comment) there are several inconsistencies in the wording and ordering of enumerated attribute "missing value default" and "invalid value default" states.

  • Some would say The <foo> attribute's while others The attribute's. Given the name of the attribute is redundant (as the prose always exists below the table and inside the heading for the attribute), it has been removed so they all read The attribute's.
  • Some would say The attribute's missing value default and invalid value default are... while others would say The attribute's invalid value default and missing value default are.... These have been made consistent.
  • Some would say The missing value default and *the* invalid value default, the redundant the has been removed.
  • Some would separate missing/invalid into two sentences, others would separate by comma. They now all separate by comma.
  • For enumerated attributes where both missing/invalid are the same, some read "are both the foo state." and others read "are the foo state.". This has been made consistent to "are both the".

Ordering "missing value default" before "invalid value default" makes them consistent based on the "Keywords an enumerated attributes" section which lists what to do about a missing attribute before it lists what to do with an invalid one.

Refs #9832.


/dnd.html ( diff )
/dom.html ( diff )
/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/forms.html ( diff )
/image-maps.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/media.html ( diff )
/obsolete.html ( diff )
/popover.html ( diff )
/tables.html ( diff )
/urls-and-fetching.html ( diff )

@keithamus keithamus force-pushed the editorial-make-the-missing-invalid-value-paras-consistent-ordering branch from 6d41424 to db030b3 Compare November 22, 2023 10:51
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure about the insertion of the comma when "and" combines two clauses, but overall this is a huge improvement and I don't want to block on that. Thanks!

@annevk annevk merged commit d24465d into whatwg:main Nov 23, 2023
@keithamus keithamus deleted the editorial-make-the-missing-invalid-value-paras-consistent-ordering branch November 23, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants