Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: clean up enumerated attribute preambles #9944

Conversation

keithamus
Copy link
Contributor

@keithamus keithamus commented Nov 21, 2023

Helps with #9832

The input type and button type attribute tables had lengthly preambles that didn't conform to the editorial changes requested in #9832 so this PR changes them to use the "with the following keywords and states" copy. I haven't altered the tables; while they deviate from others - lacking a "Brief description" and adding two additional columns - they are good as-is.


/form-elements.html ( diff )
/input.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed one small inconsistency we might want to take care of: throughout the spec, two matches for

The missing value default and the invalid value default are

and four matches for

The missing value default and invalid value default are

@keithamus keithamus force-pushed the editorial-clean-up-enumerated-attribute-preambles branch from 0bef947 to 24e048c Compare November 22, 2023 09:42
@keithamus
Copy link
Contributor Author

keithamus commented Nov 22, 2023

I've tackled one of these here as it relates to the input. Looks like the others can be tackled separately as they'll need tables anyway. Tackled in #9947.

Also looks like there's an inconsistency in ordering. I count 10 matches for missing value default and invalid while there are 6 for invalid value default and missing. See #9947 for a separate cleanup of these sections.

@keithamus keithamus force-pushed the editorial-clean-up-enumerated-attribute-preambles branch from 24e048c to e3e9dbe Compare November 23, 2023 11:57
@annevk annevk merged commit c540eaa into whatwg:main Nov 23, 2023
1 check passed
@keithamus keithamus deleted the editorial-clean-up-enumerated-attribute-preambles branch November 23, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants