Fix dialog requestClose() to handle edge case

[lukewarlow]

Fix dialog requestClose() to handle edge case

Dialog requestClose() now directly calls close the dialog if dialog's close watcher is null.

This replaces a previous assert that's wrong.

• At least two implementers are interested (and none opposed):
  • …
  • …
• Tests are written and can be reviewed and commented upon at:
  • Add requestClose() subtests for initially open dialog web-platform-tests/wpt#50432
• Implementation bugs are filed:
  • Chromium: …
  • Gecko: …
  • WebKit: …
• Corresponding HTML AAM & ARIA in HTML issues & PRs: N/A
• MDN issue is filed: N/A
• The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

---

/interactive-elements.html ( diff )

[domenic]

I guess this is more temporary patches since we haven't fixed the asymmetry between setting open and calling show().

@mfreed7 PTAL?

[lukewarlow]

I guess this is more temporary patches since we haven't fixed the asymmetry between setting open and calling show().

Yeah idk what the end result we want is, perhaps we can change this to an assert in future and make sure close watcher is created when open is added but for now this seems like the minimal fix to prevent a crash.

I think it's potentially worth a discussion at whatnot about what we envisage the end state to be for the open attribute because it causes many an issue so it might be worth spending time fully fixing it up.