Skip to content

Commit 67f78ff

Browse files
committed
Fix dialog requestClose() to handle edge case
Dialog requestClose() now directly calls close the dialog if dialog's close watcher is null. This replaces a previous assert that's wrong.
1 parent 005b463 commit 67f78ff

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

source

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62087,8 +62087,8 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {
6208762087
<li><p>If <var>this</var> does not have an <code data-x="attr-dialog-open">open</code>
6208862088
attribute, then return.</p></li>
6208962089

62090-
<li><p><span>Assert</span>: <var>this</var>'s <span data-x="dialog-close-watcher">close
62091-
watcher</span> is not null.</p></li>
62090+
<li><p>If <var>this</var>'s <span data-x="dialog-close-watcher">close watcher</span> is null, then
62091+
<span>close the dialog</span> <span>this</span> with <var>returnValue</var> and return.</p></li>
6209262092

6209362093
<li><p>Set <var>dialog</var>'s <span>enable close watcher for <code
6209462094
data-x="dom-dialog-requestClose">requestClose()</code></span> to true.</p></li>

0 commit comments

Comments
 (0)