fix: Newsletter section behaviour #706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eduardoformiga
added a commit
to vtex/faststore
that referenced
this pull request
Mar 6, 2025
## What's the purpose of this pull request? Fix the Newsletter section behavior that happens sometimes: - error when add valid email - success when add invalid email |Before|After| |-|-| ||| ## How it works? This pull request includes several changes to improve error handling and data processing in the `Newsletter` component and the `useLazyQuery` hook. The most important changes include updating the `onSubmit` function to handle errors properly and ensuring the `useLazyQuery` hook returns the updated data. ## How to test it? You can compare the behavior locally, using the current starter (with errors), or the fixed version from the Starter preview. ### Starters Deploy Preview PR - vtex-sites/starter.store#706 - preview: https://starter-oph90fa76-vtex.vercel.app/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
applies changes from
Newslettersection behaviour - SFS-2265 vtex/faststore#2703