-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifact Tracing with Health Rules #891
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I wonder about forcing explicit duplication of top-level health rules when there rules for tracing aren't different. Was there a strong case for not having such cleverness?
@sclevine and @scothis I remember that you were in favor of this. I would say that the concern was that: health rules for the purpose of reporting health on the workload will most likely be the same as those used to determine if the object was "at rest" for the purpose of artifact tracing. But there is no guarantee that's the case. So we make separate fields to put users in control. Is that a good summation? |
Have we implemented these ideas to see how they perform in a cluster? There are enough moving parts that to prove correct behavior in every situation will be difficult (the text of the RFC already indicates that we know there are cases that can deadlock a supply chain). |
If we step back and look at the larger picture of artifact tracing in the context of the Blueprints API, what would an artifact tracing native API look like? |
Changes proposed by this PR
Readable
[ ] Linked to a relevant issue. Eg:Fixes #123
orUpdates #123
wip
commits[ ] Filled in the Release Note section above[ ] Modified the docs to match changes