-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifact Tracing with Correlation Rules #894
base: main
Are you sure you want to change the base?
Conversation
Following feedback, the RFC no longer includes caching of any values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What resources choreographed by Cartographer follow this pattern today? Without knowing that we are picking up support for common patterns that exist in the wild, this proposal has an element of "if you build it, they will come" vibes. |
The only resource I know of that would fit would be Tekton, where a Tekton task status includes the spec definition that led to the output. I agree that this and Artifact Tracing with Generation Output Correlation are Cartographer encouraging the k8s resources in our domain to adopt one of these patterns. If those other resources never do, tracing will always rely on Artifact Tracing with Health Rules, which is sub-optimal. |
Readable
[ ] Linked to a relevant issue. Eg:Fixes #123
orUpdates #123
wip
commits[ ] Filled in the Release Note section above[ ] Modified the docs to match changes