Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact Tracing with Correlation Rules #894

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

waciumawanjohi
Copy link
Contributor

Readable

  • [ ] Linked to a relevant issue. Eg: Fixes #123 or Updates #123
  • Removed non-atomic or wip commits
  • [ ] Filled in the Release Note section above
  • [ ] Modified the docs to match changes

@waciumawanjohi waciumawanjohi added the rfc Requests For Comment label Jun 9, 2022
@waciumawanjohi
Copy link
Contributor Author

Following feedback, the RFC no longer includes caching of any values.

@squeedee squeedee self-requested a review June 27, 2022 18:59
Copy link
Member

@squeedee squeedee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

Copy link
Contributor

@idoru idoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scothis
Copy link
Contributor

scothis commented Jul 18, 2022

What resources choreographed by Cartographer follow this pattern today? Without knowing that we are picking up support for common patterns that exist in the wild, this proposal has an element of "if you build it, they will come" vibes.

@waciumawanjohi
Copy link
Contributor Author

What resources choreographed by Cartographer follow this pattern today? Without knowing that we are picking up support for common patterns that exist in the wild, this proposal has an element of "if you build it, they will come" vibes.

The only resource I know of that would fit would be Tekton, where a Tekton task status includes the spec definition that led to the output.

I agree that this and Artifact Tracing with Generation Output Correlation are Cartographer encouraging the k8s resources in our domain to adopt one of these patterns. If those other resources never do, tracing will always rely on Artifact Tracing with Health Rules, which is sub-optimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc Requests For Comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants