Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIVO-4056 Avoid forced capitalization of property group labels #495

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

litvinovg
Copy link
Member

@litvinovg litvinovg commented Mar 14, 2025

VIVO GitHub issue
VIVO PR

What does this pull request do?

Removed capitalization of property groups in Freemarker code
Applied capitalization to 'Other' property group option

How should this be tested?

  • Rename a property group
  • Verify that new property group label is displayed without modification in profile

Interested parties

@VIVO-project/vivo-committers

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. FreeMarker
  2. Natural language knowledge
    1. English
    2. German
    3. Spanish
    4. French
    5. Portuguese
    6. Russian
    7. Serbian

Reviewers' report template

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

@chenejac chenejac requested a review from brianjlowe March 18, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better way to deal with capitalization in property groups
2 participants