feat: track dependencies when loading config with native #19350
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Feb 4, 2025
Comment on lines
+1792
to
+1794
| // rather than a singleton, it would be better to unregister the loader | ||
| // so that it doesn't incur the overhead when not needed | ||
| // but unregistering a loader is not supported |
Member
Author
There was a problem hiding this comment.
I think my only concern is the lack of the loader unregister feature.
sapphi-red
commented
Feb 4, 2025
Member
|
One of the main concern for me about this is that this only works in node as the API isn't implemented in Bun or Deno iirc, and it's still experimental. In the past, I also thought about using But maybe it's still worth including this for now though as the config loading feature is also experimental. |
Member
|
@sapphi-red this was autoclosed. And it seems I can't reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
built on top of #19178
Adds support for restarting the server when the dependency of the config file is edited.
I haven't wrote the tests yet.