feat: use native runtime to import the config #19178
Merged
+74
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
changed the title
bluwy
force-pushed
the
config-loader-native
branch
from
e487dab to
ea8d558
Compare
patak-dev
added
p2-nice-to-have
wojtekmaj
reviewed
Jan 29, 2025
| ::: tip CONFIG LOADING | ||
| By default, Vite uses `esbuild` to bundle the config into a temporary file and load it. This may cause issues when importing TypeScript files in a monorepo. If you encounter any issues with this approach, you can specify `--configLoader runner` to use the [module runner](/guide/api-environment-runtimes.html#modulerunner) instead, which will not create a temporary config and will transform any files on the fly. Note that module runner doesn't support CJS in config files, but external CJS packages should work as usual. | ||
|
|
||
| Alternatively, if you're using an environment that supports TypeScript (e.g. `node --experimental-strip-types`), or if you're only writing plain JavaScript, you can specify `--configLoader native` to use the environment's native runtime to load the config file. Note that updates to modules imported by the config file are not detected and hence would not auto-restart the Vite server. |
There was a problem hiding this comment.
Latest Node.js versions have type stripping unflagged, maybe it would be worth mentioning.
There was a problem hiding this comment.
IIUC node 23 unflags it, but we don't really officially support odd versions of node, so I think I'd lean on not mentioning it for now.
sapphi-red
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
It feels a bit bloated that we have three ways to load the config. That said, I think it's good to evaluate this approach together with the other config loaders.
I also tested if we can keep the dependency tracking feature by using loaders in #19350. It seems it works without adding much code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref #18637 (
--configLoader runner)Adds support for
--configLoader native, which uses the environment's runtime to load the configNOTE: