Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dns): Add zeroconf client options to DNS params #206

Closed
wants to merge 1 commit into from
Closed

feat(dns): Add zeroconf client options to DNS params #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions dns/dns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ func (e CastEntry) GetPort() int {

// DiscoverCastDNSEntryByName returns the first cast dns device
// found that matches the name.
func DiscoverCastDNSEntryByName(ctx context.Context, iface *net.Interface, name string) (CastEntry, error) {
castEntryChan, err := DiscoverCastDNSEntries(ctx, iface)
func DiscoverCastDNSEntryByName(ctx context.Context, iface *net.Interface, name string, opts ...zeroconf.ClientOption) (CastEntry, error) {
castEntryChan, err := DiscoverCastDNSEntries(ctx, iface, opts...)
if err != nil {
return CastEntry{}, err
}
Expand All @@ -78,8 +78,7 @@ func DiscoverCastDNSEntryByName(ctx context.Context, iface *net.Interface, name

// DiscoverCastDNSEntries will return a channel with any cast dns entries
// found.
func DiscoverCastDNSEntries(ctx context.Context, iface *net.Interface) (<-chan CastEntry, error) {
var opts = []zeroconf.ClientOption{}
func DiscoverCastDNSEntries(ctx context.Context, iface *net.Interface, opts ...zeroconf.ClientOption) (<-chan CastEntry, error) {
if iface != nil {
opts = append(opts, zeroconf.SelectIfaces([]net.Interface{*iface}))
}
Expand Down