feat(dns): Add zeroconf client options to DNS params #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! CastSponsorSkip dev here. I have some reports of errors due to zeroconf trying to bind to an IPv6 address when IPv6 is disabled in gabe565/CastSponsorSkip#54. I suspect zeroconf.SelectIPTraffic could help, so this PR adds support for variadic parameters. This also allows for selecting multiple interfaces, by leaving the
iface
param set to nil, then passingzeroconf.SelectIfaces
directly.Honestly, it would probably be best practice to remove the
iface
param, but that would be a breaking change. If you prefer, I could change this PR to do something like this: