Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more features by default #11283

Merged
merged 15 commits into from
Feb 17, 2025
Merged

Enable more features by default #11283

merged 15 commits into from
Feb 17, 2025

Conversation

danog
Copy link
Collaborator

@danog danog commented Feb 14, 2025

No description provided.

@danog danog added the release:feature The PR will be included in 'Features' section of the release notes label Feb 14, 2025
@danog danog changed the title Enable more features by default Enable all safe features by default Feb 14, 2025
@danog danog changed the title Enable all safe features by default Enable more features by default Feb 14, 2025
@Ocramius
Copy link
Contributor

As mentioned in #11288, I believe this should target 7.x.

Discussion over there: this comment is mostly cross-linking.

@danog
Copy link
Collaborator Author

danog commented Feb 16, 2025

For future reference: #11288 (comment)

@danog danog merged commit 782756e into 6.x Feb 17, 2025
95 of 97 checks passed
@danog danog deleted the enable_more_features branch February 17, 2025 10:20
@jorgsowa
Copy link
Contributor

Feature ensureOverrideAttribute shows warnings even when we mark version to 8.2 where attribute Override is not available yet. Attribute Override is available since 8.3.

@M393
Copy link
Contributor

M393 commented Feb 17, 2025

@jorgsowa See #11301 (comment)
In lower versions it will be seen as a normal comment by php.

@danog
Copy link
Collaborator Author

danog commented Feb 17, 2025

& on php 8.0-8.2, simply require the symfony polyfill to polyfill the Override class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants