Upgrade Psalm to 6.7 and silence issues #19602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Psalm and silences all the newly enabled nonsense checks introduced in vimeo/psalm#11283:
echo 'Hello' . 42;
is perfectly fine in my opinion. Suppressing this check would require scattering explicit type casts all over the code. This really shouldn't be an issue reported by static analysis. Maybe I am missing something here, but I couldn't find any justification for this one.These checks can be enabled later on in separate PRs, but for the sake of a seamless Psalm upgrade let's keep them disabled as they previously were.