Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module ID global optimization #8913

Closed
wants to merge 1 commit into from
Closed

Module ID global optimization #8913

wants to merge 1 commit into from

Conversation

LichuAcu
Copy link

@LichuAcu LichuAcu commented Aug 1, 2024 •
edited
Loading

Description

Module ID global optimization is implemented, making use of the GlobalInformation struct. IDs become bigger as collisions appear.

Testing Instructions

@vercel Vercel
Copy link

vercel bot commented Aug 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 9:48pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 9:48pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:48pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:48pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:48pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:48pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:48pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:48pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:48pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:48pm

@LichuAcu Graphite App
Copy link
Author

LichuAcu commented Aug 1, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LichuAcu and the rest of your teammates on Graphite Graphite

@LichuAcu LichuAcu mentioned this pull request Aug 1, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024 •
edited
Loading

⚠️ This change may fail to build next-swc.

Logs 

error: failed to resolve patches for `https://github.com/vercel/turbo`

Caused by:
  patch for `turbo-tasks` in `https://github.com/vercel/turbo` failed to resolve

Caused by:
  The patch location `https://github.com/vercel/turbo?rev=fa7ea60c8fa1efe1a0aa0deed8dba7a611b89006` does not appear to contain any packages matching the name `turbo-tasks`.

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@LichuAcu LichuAcu changed the title Implemented module ID global optimization using GlobalInformation. Module ID global optimization Aug 1, 2024
@LichuAcu LichuAcu marked this pull request as ready for review August 1, 2024 16:39
@LichuAcu LichuAcu requested a review from a team as a code owner August 1, 2024 16:39
@LichuAcu LichuAcu marked this pull request as draft August 1, 2024 16:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust clippy
  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra closed this Aug 5, 2024
@sokra sokra reopened this Aug 5, 2024
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Aug 5, 2024
@sokra
Copy link
Member

sokra commented Aug 5, 2024

You need to port these PRs to next.js

@LichuAcu LichuAcu force-pushed the Module_ID_global_optimization branch from 801a1a2 to 171aaa9 Compare August 6, 2024 21:07
@LichuAcu LichuAcu force-pushed the Module_ID_global_optimization branch from 171aaa9 to 8e9f46f Compare August 6, 2024 21:46
@LichuAcu LichuAcu closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
created-by: turbopack needs: triage New issues get this label. Remove it after triage owned-by: turbopack owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LichuAcu @sokra