Add a GlobalInformation struct #8912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LichuAcu
changed the title
sokra
reviewed
Aug 5, 2024
| @@ -122,6 +123,8 @@ pub struct BrowserChunkingContext { | |||
| minify_type: MinifyType, | |||
| /// Whether to use manifest chunks for lazy compilation | |||
| manifest_chunks: bool, | |||
| /// Global information | |||
| global_information: Vc<OptionGlobalInformation>, | |||
sokra
reviewed
Aug 5, 2024
| @@ -133,6 +136,7 @@ impl BrowserChunkingContext { | |||
| asset_root_path: Vc<FileSystemPath>, | |||
| environment: Vc<Environment>, | |||
| runtime_type: RuntimeType, | |||
| global_information: Vc<OptionGlobalInformation>, | |||
There was a problem hiding this comment.
That shouldn't be passed here (we don't want to force to always pass that).
Instead add a global_information() method to pass that, similar to the other optional fields
sokra
reviewed
Aug 5, 2024
sokra
reviewed
Aug 5, 2024
sokra
reviewed
Aug 5, 2024
sokra
reviewed
Aug 5, 2024
| @@ -96,6 +99,7 @@ impl NodeJsChunkingContext { | |||
| asset_root_path: Vc<FileSystemPath>, | |||
| environment: Vc<Environment>, | |||
| runtime_type: RuntimeType, | |||
| global_information: Vc<OptionGlobalInformation>, | |||
sokra
reviewed
Aug 5, 2024
turbo-orchestrator
bot
added
needs: triage
… ChunkingContext trait. Constructing a new GlobalInformation object takes a Project parameter, giving the constructor access to global information
LichuAcu
force-pushed
the
GlobalInformation_struct
branch
from
544f700
to
721c53b
Compare
LichuAcu
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 23, 2024
### What? Refactored module ID strategies implementation to walk modules graph individually for each endpoint. Based on feedback from [next.js#68408](#68408) and [turbo#8912](vercel/turborepo#8912). Comments marked with `NOTE(LichuAcu)` are intended to make reviewing easier and will be removed before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A
GlobalInformationstruct is added, which is made available through theChunkingContexttrait. Constructing a newGlobalInformationtakes aProjectparameter, which gives the constructor access to global information.ChunkingContextbuilder methods now also take aGlobalInformationobject.Testing Instructions