Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove cli#build dependency on all tests everywhere #4962

Merged

Conversation

mehulkar
Copy link
Contributor

JS package tests don't need to build the turbo CLI before running. Rather than disabling in those workspaces, we can limit cli#build to e2e-style tests for the CLI itself

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) May 16, 2023 6:09am
examples-kitchensink-blog 🔄 Building (Inspect) May 16, 2023 6:09am
examples-native-web 🔄 Building (Inspect) May 16, 2023 6:09am
examples-tailwind-web 🔄 Building (Inspect) May 16, 2023 6:09am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 6:09am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 16, 2023 6:09am
examples-designsystem-docs ⬜️ Ignored (Inspect) May 16, 2023 6:09am
examples-gatsby-web ⬜️ Ignored (Inspect) May 16, 2023 6:09am
examples-nonmonorepo ⬜️ Ignored (Inspect) May 16, 2023 6:09am
examples-svelte-web ⬜️ Ignored (Inspect) May 16, 2023 6:09am
examples-vite-web ⬜️ Ignored (Inspect) May 16, 2023 6:09am

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

🟢 CI successful 🟢

Thanks

JS package tests don't need to build the turbo CLI before running. Rather than
disabling in those workspaces, we can limit cli#build to e2e-style tests for the CLi
itself
@mehulkar mehulkar merged commit ee25715 into main May 16, 2023
@mehulkar mehulkar deleted the mehulkar/turbo-1107-dont-build-turbo-for-every-js-package branch May 16, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants