Skip to content

Commit

Permalink
chore: Remove cli#build dependency on all tests everywhere (#4962)
Browse files Browse the repository at this point in the history
JS package tests don't need to build the turbo CLI before running.
Rather than disabling in those workspaces, we can limit cli#build to
e2e-style tests for the CLI itself
  • Loading branch information
mehulkar committed May 16, 2023
1 parent d527eb5 commit ee25715
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
"pipeline": {
"test": {
"outputs": ["coverage/**/*"],
"dependsOn": ["cli#build", "^build"]

// ^build is generically set here, we haven't fully enumerated which workspaces
// actually need to build before running tests.
"dependsOn": ["^build"]
},

// lint tasks
Expand Down
1 change: 1 addition & 0 deletions turborepo-tests/e2e/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": ["//"],
"pipeline": {
"test": {
"dependsOn": ["cli#build", "^build"],
"output": []
}
}
Expand Down

1 comment on commit ee25715

@vercel
Copy link

@vercel vercel bot commented on ee25715 May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.