Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more k8s/release friendly PR template. #1035

Merged
merged 3 commits into from
Jan 13, 2020
Merged

Use a more k8s/release friendly PR template. #1035

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab81cf7
Use a more k8s/release friendly PR template.
j0n3lson Jan 10, 2020
78ba678
Modifications per review
j0n3lson Jan 10, 2020
fd475c4
Merge branch 'master' into doc-update-pr-template
asahasrabuddhe Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 33 additions & 23 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,38 +4,57 @@
If a section of the PR template does not apply to this PR, then delete that section.
-->

## Motivation
## What type of PR is this?

_(fill-in or delete this section)_
_(REQUIRED)_

<!--
/kind bug
/kind cleanup
/kind documentation
/kind feature
-->
j0n3lson marked this conversation as resolved.
Show resolved Hide resolved

## What this PR does / why we need it:

_(REQUIRED)_

<!--
What goal is this change working towards?
Provide a bullet pointed summary of how each file was changed.
Briefly explain any decisions you made with respect to the changes.
Include anything here that you didn't include in *Release Notes*
above, such as changes to CI or changes to internal methods.
-->

## Which issue(s) this PR fixes:

_(REQUIRED)_
<!--
If this PR fixes one of more issues, list them here.
One line each, like so:
Fixes #123
Fixes #39
-->

## Release Notes
## Special notes for your reviewer:

_(fill-in or delete this section)_

<!--
If this PR makes user facing changes, please describe them here.
This description will be copied into the release notes, whenever
the next version is released. Keep this section short, and
focus on high level changes.
Is there any particular feedback you would / wouldn't like?
Which parts of the code should reviewers focus on?
-->

## Changes
## Release Notes

_(fill-in or delete this section)_
_(REQUIRED)_
saschagrunert marked this conversation as resolved.
Show resolved Hide resolved

<!--
Provide a bullet pointed summary of how each file was changed.
Briefly explain any decisions you made with respect to the changes.
Include anything here that you didn't include in *Release Notes*
above, such as changes to CI or changes to internal methods.
If this PR makes user facing changes, please describe them here. This
description will be copied into the release notes/changelog, whenever the
next version is released. Keep this section short, and focus on high level
changes.
-->

## Testing
Expand All @@ -44,13 +63,4 @@ _(fill-in or delete this section)_

<!--
Describe how you tested this change.
-->

## Reviewer Guidelines

_(fill-in or delete this section)_

<!--
Is there any particular feedback you would / wouldn't like?
Which parts of the code should reviewers focus on?
-->
-->