Use a more k8s/release friendly PR template. #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lynncyrin All yours! |
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
======================================
Coverage 72.6% 72.6%
======================================
Files 33 33
Lines 2482 2482
======================================
Hits 1802 1802
Misses 569 569
Partials 111 111Continue to review full report at Codecov.
|
|
I'm going to edit the PR description very slightly, since this PR shouldn't close #965 just yet 🙂 |
Done! ✅ |
coilysiren
previously approved these changes
Jan 10, 2020
|
Not sure why tests are failing? Someone please investigate 🙏 |
|
Ah, master is failing 🙁 #1037 |
coilysiren
approved these changes
Jan 10, 2020
|
This should pass once the master is merged with this branch. |
|
Looks like this is good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Modifying the PR template will will enable easier parsing kubernetes release-notes tool (tracked in #965). The tool makes some assumptions about PR bodies so limiting drift between those assumptions and the PR template should make release note generation more reliable.
Which issue(s) this PR fixes:
Partially addresses #965
Special notes for your reviewer:
Tried to keep the spirit of the original template but I've made some sections "Required" if they are important to release notes generation. Also I assume the list of "allowed" labels has been updated (or will be) based on the labels in this template.