Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter children to slides only when determining number of slides #708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Filter children to slides only when determining number of slides #708

wants to merge 1 commit into from

Commits on Nov 20, 2014

  1. Filter children to slides only when determining number of slides 

    When using MVC frameworks (Ember) to generate the HTML, additional
`<script>` nodes are inserted inside the `.slide-group` element. These
extra nodes get returned by `slider.children`, causing an incorrect
number of slides to be calculated, and hence when scrolling to the end
of the slides, you scroll into nothingness.

This patch counts only the `.slide` nodes within the slider to get the
correct slide count.
    @diazruy
    diazruy committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    8acc21b View commit details
    Browse the repository at this point in the history