Filter children to slides only when determining number of slides #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using MVC frameworks (Ember) to generate the HTML, additional `<script>` nodes are inserted inside the `.slide-group` element. These extra nodes get returned by `slider.children`, causing an incorrect number of slides to be calculated, and hence when scrolling to the end of the slides, you scroll into nothingness. This patch counts only the `.slide` nodes within the slider to get the correct slide count.
diazruy
force-pushed
the
slide_count_fix
branch
from
8a08039
to
8acc21b
Compare
|
Sidenote: You should upgrade to Ember 1.8 where those wacky metamorphs are gone. |
|
That's the plan, but unfortunately at the moment we're on 1.6.0.beta2 and even just upgrading to 1.6 stable breaks things. We're on a bit of a time-crunch, so we're just pushing forward as is for now. Nice to know that 1.8 removes those, because I found them quite annoying. |
|
/CC @connors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using MVC frameworks (Ember) to generate the HTML, additional
<script>nodes are inserted inside the.slide-groupelement. These extra nodes getreturned by
slider.children, causing an incorrect number of slides tobe calculated, and hence when scrolling to the end of the slides, you
scroll into nothingness.