-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error message with stdout/stderr in the case of sharing command fails #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i4ki
force-pushed
the
i4k-fix-sharing-errors
branch
from
November 28, 2024 21:26
363ce81
to
b692a68
Compare
|
i4ki
force-pushed
the
i4k-fix-sharing-errors
branch
2 times, most recently
from
November 28, 2024 21:40
397bfa4
to
f33f341
Compare
|
…ails. Signed-off-by: i4k <[email protected]>
i4ki
force-pushed
the
i4k-fix-sharing-errors
branch
from
November 28, 2024 22:09
f33f341
to
286454c
Compare
Preview of ubuntu-focal/go1.21 tests in 31745d2🔍 View Details on Terramate Cloud .
cmd/terramate/cli
e2etests/core |
Preview of macos-ventura/go1.21 tests in 31745d2🔍 View Details on Terramate Cloud .
cmd/terramate/cli
e2etests/core |
snakster
reviewed
Nov 29, 2024
Co-authored-by: Sebastian <[email protected]>
…-sharing-errors Signed-off-by: i4k <[email protected]>
snakster
previously approved these changes
Nov 29, 2024
…-sharing-errors Signed-off-by: i4k <[email protected]>
i4ki
force-pushed
the
i4k-fix-sharing-errors
branch
from
November 29, 2024 14:33
9e65ba0
to
31745d2
Compare
snakster
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improve the error message by including the stdout and stderr of failed Outputs Sharing command.
Which issue(s) this PR fixes:
Fixes #1975
Special notes for your reviewer:
Does this PR introduce a user-facing change?