Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message with stdout/stderr in the case of sharing command fails #1984

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Nov 28, 2024

What this PR does / why we need it:

Improve the error message by including the stdout and stderr of failed Outputs Sharing command.

Which issue(s) this PR fixes:

Fixes #1975

Special notes for your reviewer:

Does this PR introduce a user-facing change?

yes, fixes an issue

@i4ki i4ki requested a review from a team as a code owner November 28, 2024 21:25
@i4ki i4ki force-pushed the i4k-fix-sharing-errors branch from 363ce81 to b692a68 Compare November 28, 2024 21:26
Copy link

github-actions bot commented Nov 28, 2024

2024/11/29 14:35:16 Terraform detected version: 1.9.8
toolsetPath: /tmp/cmd-terramate-test-2210613270
=== RUN   TestInteropCloudSyncPreview
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
--- PASS: TestInteropCloudSyncPreview (12.07s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift (6.25s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id (5.82s)
=== RUN   TestInteropSyncDeployment
=== RUN   TestInteropSyncDeployment/deployment:_empty
=== RUN   TestInteropSyncDeployment/deployment:_empty-uppercase-id
--- PASS: TestInteropSyncDeployment (37.57s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty (19.03s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty-uppercase-id (18.54s)
=== RUN   TestInteropDrift
=== RUN   TestInteropDrift/drift:_basic-drift
=== RUN   TestInteropDrift/drift:_basic-drift-uppercase-id
--- PASS: TestInteropDrift (62.31s)
    --- PASS: TestInteropDrift/drift:_basic-drift (31.76s)
    --- PASS: TestInteropDrift/drift:_basic-drift-uppercase-id (30.55s)
PASS
ok  	github.com/terramate-io/terramate/e2etests/cloud/interop	171.055s

@i4ki i4ki force-pushed the i4k-fix-sharing-errors branch 2 times, most recently from 397bfa4 to f33f341 Compare November 28, 2024 21:40
Copy link

github-actions bot commented Nov 28, 2024

metric: time/op
ChangeDetection-4: old 4.11ms ± 5%: new 4.10ms ± 3%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 13.4ms ± 4%: new 13.4ms ± 5%: delta: 0.00%
CloudReadLines-4: old 1.05ms ± 3%: new 1.06ms ± 6%: delta: 1.18%
CloudReadLine-4: old 7.46ms ± 1%: new 7.44ms ± 1%: delta: 0.00%
ListFiles-4: old 87.6µs ± 2%: new 87.5µs ± 1%: delta: 0.00%
Generate-4: old 1.58s ± 2%: new 1.57s ± 4%: delta: 0.00%
GenerateRegex-4: old 1.08s ± 5%: new 1.08s ± 4%: delta: 0.00%
TokensForExpressionComplex-4: old 1.26ms ± 1%: new 1.27ms ± 1%: delta: 0.32%
TokensForExpressionPlainStringNoNewline-4: old 798ns ± 1%: new 794ns ± 1%: delta: -0.46%
TokensForExpressionStringWith100Newlines-4: old 24.2µs ± 1%: new 24.1µs ± 1%: delta: -0.66%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.46ms ± 1%: new 1.45ms ± 1%: delta: -0.31%
TokensForExpression-4: old 1.27ms ± 1%: new 1.26ms ± 1%: delta: 0.00%
PartialEvalComplex-4: old 546µs ± 2%: new 551µs ± 2%: delta: 0.94%
PartialEvalSmallString-4: old 3.98µs ± 1%: new 3.93µs ± 1%: delta: -1.39%
PartialEvalHugeString-4: old 2.02ms ± 0%: new 1.92ms ± 1%: delta: -4.92%
PartialEvalHugeInterpolatedString-4: old 5.05ms ± 2%: new 5.02ms ± 1%: delta: -0.62%
PartialEvalObject-4: old 27.3µs ± 2%: new 27.4µs ± 1%: delta: 0.00%
TmAllTrueLiteralList-4: old 622µs ± 1%: new 624µs ± 2%: delta: 0.00%
TmAllTrueFuncall-4: old 20.6µs ± 2%: new 20.6µs ± 1%: delta: 0.00%
TmAnyTrueLiteralList-4: old 4.90ms ± 1%: new 4.88ms ± 1%: delta: -0.38%
TmAnyTrueFuncall-4: old 21.0µs ± 2%: new 20.9µs ± 1%: delta: 0.00%
TmTernary-4: old 2.54µs ± 1%: new 2.52µs ± 1%: delta: -0.81%
TmTryUnknownFunc-4: old 2.28µs ± 1%: new 2.28µs ± 1%: delta: 0.00%
TmTryUnknownVariable-4: old 2.20µs ± 1%: new 2.20µs ± 1%: delta: 0.00%
TmTryUnknownObjectKey-4: old 2.52µs ± 1%: new 2.52µs ± 1%: delta: 0.00%
metric: alloc/op
ChangeDetection-4: old 353kB ± 0%: new 356kB ± 0%: delta: 0.71%
ChangeDetectionTFAndTG-4: old 4.81MB ± 0%: new 4.81MB ± 0%: delta: 0.00%
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 27.6kB ± 0%: new 27.6kB ± 0%: delta: 0.01%
Generate-4: old 2.24GB ± 0%: new 2.24GB ± 0%: delta: 0.00%
GenerateRegex-4: old 926MB ± 0%: new 926MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 395kB ± 0%: new 394kB ± 0%: delta: -0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.5kB ± 0%: new 12.5kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 395kB ± 0%: new 395kB ± 0%: delta: -0.00%
TokensForExpression-4: old 395kB ± 0%: new 394kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 361kB ± 0%: new 361kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.95kB ± 0%: new 1.95kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 196kB ± 0%: new 196kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.31MB ± 0%: new 4.31MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 19.4kB ± 0%: new 19.4kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 321kB ± 0%: new 321kB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 10.6kB ± 0%: new 10.6kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 2.09MB ± 0%: new 2.09MB ± 0%: delta: -0.00%
TmAnyTrueFuncall-4: old 10.7kB ± 0%: new 10.7kB ± 0%: delta: 0.00%
TmTernary-4: old 1.18kB ± 0%: new 1.18kB ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 784B ± 0%: new 784B ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 768B ± 0%: new 768B ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 952B ± 0%: new 952B ± 0%: delta: 0.00%
metric: allocs/op
ChangeDetection-4: old 2.39k ± 0%: new 2.45k ± 0%: delta: 2.47%
ChangeDetectionTFAndTG-4: old 33.6k ± 0%: new 33.7k ± 0%: delta: 0.25%
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 335 ± 0%: new 335 ± 0%: delta: 0.00%
Generate-4: old 25.7M ± 0%: new 25.7M ± 0%: delta: 0.01%
GenerateRegex-4: old 18.4M ± 0%: new 18.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.78k ± 0%: new 3.78k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 26.0 ± 0%: new 26.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 38.0 ± 0%: new 38.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 26.1k ± 0%: new 26.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 183 ± 0%: new 183 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 5.94k ± 0%: new 5.94k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 275 ± 0%: new 275 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 59.6k ± 0%: new 59.6k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 277 ± 0%: new 277 ± 0%: delta: 0.00%
TmTernary-4: old 27.0 ± 0%: new 27.0 ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%

@i4ki i4ki marked this pull request as draft November 28, 2024 21:46
@i4ki i4ki force-pushed the i4k-fix-sharing-errors branch from f33f341 to 286454c Compare November 28, 2024 22:09
@i4ki i4ki marked this pull request as ready for review November 28, 2024 22:13
Copy link

github-actions bot commented Nov 28, 2024

Preview of ubuntu-focal/go1.21 tests in 31745d2

🔍 View Details on Terramate Cloud

.
cmd/terramate/cli
e2etests/core

Copy link

github-actions bot commented Nov 28, 2024

Preview of macos-ventura/go1.21 tests in 31745d2

🔍 View Details on Terramate Cloud

.
cmd/terramate/cli
e2etests/core

CHANGELOG.md Outdated Show resolved Hide resolved
snakster
snakster previously approved these changes Nov 29, 2024
@i4ki i4ki force-pushed the i4k-fix-sharing-errors branch from 9e65ba0 to 31745d2 Compare November 29, 2024 14:33
@i4ki i4ki merged commit d69c277 into main Nov 29, 2024
7 checks passed
@i4ki i4ki deleted the i4k-fix-sharing-errors branch November 29, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Terramate Swallows Tofu Errors When Getting Stack Output
2 participants