fix: error message with stdout/stderr in the case of sharing command …

…fails (#1984)

## What this PR does / why we need it:

Improve the error message by including the stdout and stderr of failed
Outputs Sharing command.

## Which issue(s) this PR fixes:
Fixes #1975

## Special notes for your reviewer:

## Does this PR introduce a user-facing change?
```
yes, fixes an issue
```

CHANGELOG.md

@@ -34,8 +34,9 @@ Given a version number `MAJOR.MINOR.PATCH`, we increment the:
 
 - Fix the command-line parsing of `run` and `script run` which were not failing from unknown flags.
 - Fix `create --all-terragrunt` creating Terragrunt stacks with cycles.
-- Panic in the Terragrunt integration when the project had modules with dependency paths outside the current Terramate project.
-  - Now Terramate throw a warning for such configurations.
+- Improve the error reporting of the Outputs Sharing feature.
+- Fix crash in the Terragrunt integration when the project had modules with dependency paths outside the current Terramate project.
+  - A warning will be shown for such configurations.
 
 ## v0.11.3
 

cmd/terramate/cli/run.go

@@ -492,7 +492,7 @@ func (c *cli) runAll(
 						err := cmd.Run()
 						if err != nil {
 							if !task.MockOnFail {
-								errs.Append(errors.E(err, "failed to execute: %s (stderr: %s)", cmd.String(), stderr.Bytes()))
+								errs.Append(errors.E(err, "failed to execute: (cmd: %s) (stdout: %s) (stderr: %s)", cmd.String(), stdout.String(), stderr.String()))
 								c.cloudSyncAfter(cloudRun, runResult{ExitCode: -1}, errors.E(ErrRunCommandNotExecuted, err))
 								releaseResource()
 								failedTaskIndex = taskIndex
@@ -502,7 +502,10 @@ func (c *cli) runAll(
 								break tasksLoop
 							}
 
-							printer.Stderr.Warnf("failed to execute `sharing_backend` command: %v", err)
+							printer.Stderr.WarnWithDetails(
+								"failed to execute `sharing_backend` command",
+								errors.E(err, "(cmd: %s) (stdout: %s) (stderr: %s)", cmd.String(), stdout.String(), stderr.String()),
+							)
 						} else {
 							stdoutBytes := stdout.Bytes()
 							typ, err := json.ImpliedType(stdoutBytes)

e2etests/core/run_parallel_test.go

@@ -151,23 +151,23 @@ func TestParallelSharingOutputFailure(t *testing.T) {
 		RunExpected{
 			Status:       1,
 			IgnoreStdout: true,
-			StderrRegex:  regexp.QuoteMeta("failed to execute: does_not_exist"),
+			StderrRegex:  regexp.QuoteMeta("failed to execute: (cmd: does_not_exist)"),
 		},
 	)
 	AssertRunResult(t,
 		tmcli.Run("run", "--enable-sharing", "--continue-on-error", "--parallel=2", "--quiet", "--", HelperPath, "echo", "okay"),
 		RunExpected{
 			Status:       1,
 			IgnoreStdout: true,
-			StderrRegex:  regexp.QuoteMeta("failed to execute: does_not_exist"),
+			StderrRegex:  regexp.QuoteMeta("failed to execute: (cmd: does_not_exist)"),
 		},
 	)
 	AssertRunResult(t,
 		tmcli.Run("run", "--dry-run", "--enable-sharing", "--continue-on-error", "--parallel=2", "--quiet", "--", HelperPath, "echo", "okay"),
 		RunExpected{
 			Status:       1,
 			IgnoreStdout: true,
-			StderrRegex:  regexp.QuoteMeta("failed to execute: does_not_exist"),
+			StderrRegex:  regexp.QuoteMeta("failed to execute: (cmd: does_not_exist)"),
 		},
 	)
 }

e2etests/core/run_sharing_test.go

@@ -370,7 +370,10 @@ func TestRunSharing(t *testing.T) {
 						"local_file.s3_file",
 					},
 					NoStdoutRegex: "local_file.s2_file",
-					StderrRegex:   regexp.QuoteMeta("Warning: failed to execute `sharing_backend` command: exit status 1"),
+					StderrRegexes: []string{
+						regexp.QuoteMeta("Warning: failed to execute `sharing_backend`"),
+						regexp.QuoteMeta("helper exit 1) (stdout: ) (stderr: ): exit status 1"),
+					},
 				})
 			},
 		},