Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart: Add extra_args + related fixes #1033

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Conversation

tbzatek
Copy link
Member

@tbzatek tbzatek commented Jun 13, 2024

This addresses the postponed TODO point from #835.
Related UDisks fixes will come in storaged-project/udisks#1289

@tbzatek tbzatek marked this pull request as draft June 19, 2024 17:03
@tbzatek tbzatek marked this pull request as ready for review June 20, 2024 13:50
tbzatek added 4 commits June 20, 2024 16:06
There's a need for a more complex exec func to capture
stdout and stderr separately.
There's a difference in how the device is accessed. While libatasmart
will happily send requests to the device and just expect an error,
smartctl tries to guess device type and refuses to do anything if unknown
(or abstracted e.g. by dm-multipath). This can be overriden by an extra
argument, libblockdev API just needs a way to provide such override.
Not the best test case, garbage data may vary.
@tbzatek tbzatek changed the title smart: Add device_type argument smart: Add extra_args + related fixes Jun 20, 2024
Collected from storaged-project/udisks#568,
verified proper temperature reporting.
@tbzatek tbzatek merged commit 025802b into storaged-project:master Jun 21, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants