smart: Add extra_args + related fixes #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
There's a need for a more complex exec func to capture stdout and stderr separately.
There's a difference in how the device is accessed. While libatasmart will happily send requests to the device and just expect an error, smartctl tries to guess device type and refuses to do anything if unknown (or abstracted e.g. by dm-multipath). This can be overriden by an extra argument, libblockdev API just needs a way to provide such override.
Not the best test case, garbage data may vary.
tbzatek
changed the title
Collected from storaged-project/udisks#568, verified proper temperature reporting.
vojtechtrefny
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the postponed TODO point from #835.
Related UDisks fixes will come in storaged-project/udisks#1289