Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle genes that are longer than max-LZ-region #51

Open
pjvandehaar opened this issue Mar 1, 2017 · 0 comments
Open

Handle genes that are longer than max-LZ-region #51

pjvandehaar opened this issue Mar 1, 2017 · 0 comments
Labels

Comments

@pjvandehaar
Copy link
Collaborator

pjvandehaar commented Mar 1, 2017

gls = [l.strip().split() for l in open('genes.bed')]
gls
gls2 = [(int(g[2]) - int(g[1]), g[0], g[3], g[4]) for g in gls]
len([g for g in gls2 if g[0] > 500e3])
# 311
sorted(gls2)[-1]
# (2304996, '7', 'CNTNAP2', 'ENSG00000174469')

Indeed, http://pheweb.sph.umich.edu/gene/CNTNAP2 is broken. How do we fix this?

Option 1: zoom in on part of gene with significance (Nah)

For that, we either must:

  • record where the significance is
  • go back and look it up when the page is requested

Option 2: do binning/subsetting for LZ

  • Option 2a: subset in LZ rendering. (but hold onto all data)

  • Option 2b: subset in api.
    LocusZoom re-requests every time the region changes, even when you zoom in, so this should work great.
    Heap the top 1000 variants for all LZ requests. Remove the region limit. Include {num_dropped_variants: 3500000, best_dropped_pval: 2.3e-3} in the response and display that somewhere. (Maybe dump it in Layout.state and put that in dashboard?

@pjvandehaar pjvandehaar changed the title Find longest gene and make sure out max-LZ-region-length handles it Find longest gene and make sure our max-LZ-region-length handles it Mar 1, 2017
@pjvandehaar pjvandehaar changed the title Find longest gene and make sure our max-LZ-region-length handles it Handle genes that are longer than max-LZ-region Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant