-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering performance improvements #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fa2ee8
to
accb4b7
Compare
Few people use this functionality, and it adds weight and extra code to the DOM. In the future we may want to repurpose shiftclick behavior for some other purpose, like labeling points on a scatter plot. For now disable the current usage.
…se regions (there are so many loops that trying to assign rigorously separate category colors just created visual noise)
fc53e54
to
292a8cc
Compare
cc2f228
to
6a90b58
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
LocusZoom becomes very slow when loading dense regions (with a lot of variants). Some users would like to increase
max_region_size
and/or render modern datasets that may be imputed to better panels.This ticket contains some initial low-hanging performance improvements:
Summary of changes
coalesce._
control whether to group together nearby points, and if so, what parameters to use. By default it groups together adjacent points within ~1 circle-diameter distance of each other in x and y.Bugfixes:
TODO