Skip to content
This repository has been archived by the owner on Jul 21, 2024. It is now read-only.

BN-83 GPU support integration #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

slatunje
Copy link

Signed-off-by: Sylvester La-Tunje [email protected]
(cherry picked from commit a69c56c)

Signed-off-by: Sylvester La-Tunje <[email protected]>
(cherry picked from commit a69c56c)
@slatunje slatunje changed the title cuda gpu spike using custom images BN-83 GPU support integration Oct 23, 2020
Copy link
Member

@rabits rabits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks like a simple change but for sure will require generalization and additional logic for AWS & local providers... Will check how to do that.

Also could you please attach some example blend file to test CUDA properly? Something that will clearly show that the CUDA is working, not just CPU

BlendNet/providers/gcp/__init__.py Outdated Show resolved Hide resolved
BlendNet/providers/gcp/__init__.py Outdated Show resolved Hide resolved
@@ -491,6 +529,8 @@ def createInstanceAgent(cfg):
'description': 'BlendNet Agent worker',
'scheduling': {
'preemptible': cfg['use_cheap_instance'],
'onHostMaintenance': 'TERMINATE',
'automaticRestart': True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually Manager should decide what to do with the agent instance.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were simply added to allow me to get gpu working.
Feel free to move it to where is fits best as I do not know the code base very well

BlendNet/providers/gcp/__init__.py Outdated Show resolved Hide resolved
@rabits rabits added the enhancement New feature or request label Oct 23, 2020
@slatunje
Copy link
Author

Ok, looks like a simple change but for sure will require generalization and additional logic for AWS & local providers... Will check how to do that.

Thanks. In addition to these logic per provider, there needs to be logic per GPU availability per zone.

Also could you please attach some example blend file to test CUDA properly? Something that will clearly show that the CUDA is working, not just CPU

I used private blend files from a private project and I also used the barbershop https://www.blender.org/download/demo-files/#cycles for gpu.

Barbershop took too long as I only have 1 gpu quota so was unable to test huge files all the way. Only long enough to see the gpu's working on metrics and within nvidia_smi

@rabits
Copy link
Member

rabits commented Oct 23, 2020

Ok, glad it's working for you - but seems it will need adjustments to fit everywhere, so I think will move these activity to v0.5

Signed-off-by: Sylvester La-Tunje <[email protected]>
note this will increase build time

Signed-off-by: Sylvester La-Tunje <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants