Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a POC about include convention.
Right now, there is include convention. This lead to some issues:
Since Pinocchio is header only, we can't use the include what you use convention since it will create a lot of cycle.
In this PR we propose to change the include convention as the following:
xxx.hpp
xxx-def.hxx
xxx-decl.hxx
xxx-tpl.hxx
With the following rules:
This should prevent cyclic include and with some .clangd trick will improve the LSP processing.
All is described in development/convention.md.
Constraints