Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(security): add UserPermissionEvaluator #1179

Merged
merged 2 commits into from
Apr 27, 2024

Commits on Apr 26, 2024

  1. feat(security): add UserPermissionEvaluator

    so S3ArtifactStoreGetter can call a username-based hasPermission method.
    FiatPermissionEvaluator has this method, but using FiatPermissionEvaluator in kork would
    create a circular dependency.
    
    The plan is:
    
    - publish a kork jar with UserPermissionEvaluator,
    - consume it in fiat and change FiatPermissionEvaluator to implement UserPermissionEvaluator instead of PermissionEvaluator
    - publish a fiat jar and consume it everywhere
    - change S3ArtifactStoreGetter to use UserPermissionEvaluator to fix the bug that spinnaker#1178 demonstrates
    - publish yet another kork jar and consume it everywhere to fix use of fetchReference in Evaluate Variables stages
    dbyron-sf committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    791c9e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Configuration menu
    Copy the full SHA
    82593c8 View commit details
    Browse the repository at this point in the history