feat(security): add UserPermissionEvaluator #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so S3ArtifactStoreGetter can call a username-based hasPermission method. FiatPermissionEvaluator has this method, but using FiatPermissionEvaluator in kork would create a circular dependency. The plan is: - publish a kork jar with UserPermissionEvaluator, - consume it in fiat and change FiatPermissionEvaluator to implement UserPermissionEvaluator instead of PermissionEvaluator - publish a fiat jar and consume it everywhere - change S3ArtifactStoreGetter to use UserPermissionEvaluator to fix the bug that spinnaker#1178 demonstrates - publish yet another kork jar and consume it everywhere to fix use of fetchReference in Evaluate Variables stages
dbyron-sf
force-pushed
the
add-UserPermissionEvaluator
branch
from
684c599
to
791c9e8
Compare
xibz
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so S3ArtifactStoreGetter can call a username-based hasPermission method. FiatPermissionEvaluator has this method, but using FiatPermissionEvaluator in kork would create a circular dependency.
The plan is: