Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Play video as audio #471

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Play video as audio #471

wants to merge 2 commits into from

Conversation

myl7
Copy link
Collaborator

@myl7 myl7 commented Feb 19, 2022

The PR updates the preview selection system and adds a switching button to allow users to switch from video preview to audio preview. With <audio>, one of the most important features is to allow to play audios on the background after locking mobile device screens, as <video> would stop immediately at that time. The control flag will be reset after path changes.

DRAWBACK: While ordinary audio covers are square, the video thumbnails may be rectangular, which causes round CD-like spinning covers become oval ones that looks strange.

@vercel
Copy link

vercel bot commented Feb 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/spencerwoo/onedrive-vercel-index/EyZiNKrH7bz11tkPj58LWmjUGkRw
✅ Preview: https://onedrive-vercel-index-git-fork-myl7-video-as-audio-spencerwoo.vercel.app

@spencerwooo
Copy link
Owner

to be honest, I personally don't think this is necessary ;)

@spencerwooo spencerwooo added the feature request New feature or request label Feb 24, 2022
@myl7
Copy link
Collaborator Author

myl7 commented Feb 24, 2022

One example is music videos. As original music files often contain DRM, many people choose to download the MV version. To selfhost the MV files on the app and listen them on background, they need a way to play the video files on background.

@myl7 myl7 mentioned this pull request May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants