-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Docker build config #643
base: main
Are you sure you want to change the base?
Docker build config #643
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
你可以看下之前和docker相关的PR,作者有说他不接受合并到主分支 https://github.com/spencerwooo/onedrive-vercel-index/pulls?q=is%3Apr+docker |
私以为 PR 除了以合入主线为末路以外,也可以提供一套解决方案,或者更具体地说,带代码的 show & tell |
他建议放在讨论区或者gist上,具体等作者回复吧,估计不大会合并,我之前也折腾过😂 |
放 discussion 或者 gists 就没 git log 了,会丢失很多信息的 |
This can be partially* solved by allowing every config option to be set by environment variable. config/api.config.js
& config/site.config.js
*This works fine for variables, however, it doesn't work for arrays. Arrays cannot be replaced by environment variables. This affects |
Since there are many hot discussions about selfhosting the project (disscussion #595 #633 #518), the PR adds some simple Docker build config for the project, to help users serve the project with Docker by themselves easily.
To serve the project, build the Docker image and run it like:
One problem is that since the 2 config files are bundled, when the config files change the Docker image needs to be rebuilt.
There is a similar discussion #112 having talked about selfhosting deployment, but times goes by and many components changed. I would suggest including the selfhosting deployment config into the repo for better maintanance.