Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix air/vac of SDSS and SDSS IV line lists #3458

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 21, 2025

Description

This pull request is to address line list problem reported by Cami.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added bug Something isn't working trivial Only needs one approval instead of two backport-v4.1.x on-merge: backport to v4.1.x labels Feb 21, 2025
@pllim pllim added this to the 4.1.2 milestone Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base (e6548c4) to head (3230ba8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3458   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files         128      128           
  Lines       20041    20041           
=======================================
  Hits        17553    17553           
  Misses       2488     2488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camipacifici
Copy link
Contributor

Thanks! Matches what is in the notes now.

@pllim pllim marked this pull request as ready for review February 21, 2025 20:27
Remove SDSS IV lambda < 2000 because it is vacuum but we only want air.

Add change log.
Comment on lines -2 to -6
Ly-α,1215.67,Emission
N V 1240,1240.81,Emission
C IV 1549,1549.48,Emission
He II 1640,1640.42,Emission
C III] 1908,1908.734,Emission
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these removed? Are they also listed in the SDSS entry and just removed here since they're under 2000 A? Do we need to note that in the changelog or no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added change log.

@pllim pllim enabled auto-merge (squash) February 24, 2025 15:04
@pllim pllim merged commit 7ec2782 into spacetelescope:main Feb 24, 2025
19 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Feb 24, 2025
@pllim pllim deleted the sdss-air-vac branch February 24, 2025 15:39
pllim added a commit that referenced this pull request Feb 24, 2025
…8-on-v4.1.x

Backport PR #3458 on branch v4.1.x (BUG: Fix air/vac of SDSS and SDSS IV line lists)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x bug Something isn't working trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants