-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix air/vac of SDSS and SDSS IV line lists #3458
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3458 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 128 128
Lines 20041 20041
=======================================
Hits 17553 17553
Misses 2488 2488 ☔ View full report in Codecov by Sentry. |
Thanks! Matches what is in the notes now. |
Remove SDSS IV lambda < 2000 because it is vacuum but we only want air. Add change log.
Ly-α,1215.67,Emission | ||
N V 1240,1240.81,Emission | ||
C IV 1549,1549.48,Emission | ||
He II 1640,1640.42,Emission | ||
C III] 1908,1908.734,Emission |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these removed? Are they also listed in the SDSS entry and just removed here since they're under 2000 A? Do we need to note that in the changelog or no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added change log.
Co-authored-by: Kyle Conroy <[email protected]>
…8-on-v4.1.x Backport PR #3458 on branch v4.1.x (BUG: Fix air/vac of SDSS and SDSS IV line lists)
Description
This pull request is to address line list problem reported by Cami.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.