Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3458 on branch v4.1.x (BUG: Fix air/vac of SDSS and SDSS IV line lists) #3459

Conversation

meeseeksmachine
Copy link

Backport PR #3458: BUG: Fix air/vac of SDSS and SDSS IV line lists

@lumberbot-app lumberbot-app bot added this to the 4.1.2 milestone Feb 24, 2025
@lumberbot-app lumberbot-app bot added the bug Something isn't working label Feb 24, 2025
@lumberbot-app lumberbot-app bot added the trivial Only needs one approval instead of two label Feb 24, 2025
@lumberbot-app lumberbot-app bot added the backport-v4.1.x on-merge: backport to v4.1.x label Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v4.1.x@74d5d5d). Learn more about missing BASE report.
Report is 2 commits behind head on v4.1.x.

Additional details and impacted files
@@            Coverage Diff            @@
##             v4.1.x    #3459   +/-   ##
=========================================
  Coverage          ?   88.11%           
=========================================
  Files             ?      127           
  Lines             ?    19625           
  Branches          ?        0           
=========================================
  Hits              ?    17293           
  Misses            ?     2332           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim merged commit a1fc36b into spacetelescope:v4.1.x Feb 24, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x bug Something isn't working trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants