Allow more items on skewers; cookable snake meat and spider legs#43597
Open
themias wants to merge 5 commits intospace-wizards:masterfrom
Open
Allow more items on skewers; cookable snake meat and spider legs#43597themias wants to merge 5 commits intospace-wizards:masterfrom
themias wants to merge 5 commits intospace-wizards:masterfrom
Conversation
Contributor
Contributor
Author
|
Looks like this package was marked vulnerable in the last 24 hours: /home/runner/work/space-station-14/space-station-14/Content.Server.Database/Content.Server.Database.csproj : error NU1901: Warning As Error: Package 'System.Security.Cryptography.Xml' 9.0.0 has a known low severity vulnerability, GHSA-37gx-xxp4-5rgx [/home/runner/work/space-station-14/space-station-14/Content.Server/Content.Server.csproj] |
Member
|
Frozen until #43412 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

About the PR
This PR allows all cutlets, lingzhi mushrooms, cooked snake meat, and cooked spider legs to go on skewers.
It also allows snake meat and spider legs to be cooked, and spider legs to drop from butchered giant spiders.
I don't think this is blocked by any freezes, as it doesn't add any recipes or modify microwave code.
I can also split this PR into smaller ones if desired.
Mostly fixes #41223 (one sprite unused, and alpha sprites are not currently supported)
Why / Balance
It is confusing for some meat to be cookable and usable in food sequences, but others aren't. This makes the behavior more intuitive for the player. It also gives more purpose to the grill and gives certain ingredients more utiliy.
Technical details
We had bits and pieces of these things in the code, but this PR just brings them together. There was some clean up to do, e.g. cooked spider legs did not parent raw spider legs, meat cutlets were missing their sequence name, etc.
Food sequences use sprite specifiers, so we can't use alpha/grayscale sprites until coloring support is added for them: space-wizards/RobustToolbox#6519
Media
Requirements
Changelog
🆑