Skip to content

Allow more items on skewers; cookable snake meat and spider legs#43597

Open
themias wants to merge 5 commits intospace-wizards:masterfrom
themias:skewer-implement-remains
Open

Allow more items on skewers; cookable snake meat and spider legs#43597
themias wants to merge 5 commits intospace-wizards:masterfrom
themias:skewer-implement-remains

Conversation

@themias
Copy link
Copy Markdown
Contributor

@themias themias commented Apr 15, 2026

About the PR

This PR allows all cutlets, lingzhi mushrooms, cooked snake meat, and cooked spider legs to go on skewers.
It also allows snake meat and spider legs to be cooked, and spider legs to drop from butchered giant spiders.

I don't think this is blocked by any freezes, as it doesn't add any recipes or modify microwave code.
I can also split this PR into smaller ones if desired.

Mostly fixes #41223 (one sprite unused, and alpha sprites are not currently supported)

Why / Balance

It is confusing for some meat to be cookable and usable in food sequences, but others aren't. This makes the behavior more intuitive for the player. It also gives more purpose to the grill and gives certain ingredients more utiliy.

Technical details

We had bits and pieces of these things in the code, but this PR just brings them together. There was some clean up to do, e.g. cooked spider legs did not parent raw spider legs, meat cutlets were missing their sequence name, etc.

Food sequences use sprite specifiers, so we can't use alpha/grayscale sprites until coloring support is added for them: space-wizards/RobustToolbox#6519

Media

skewer-screenshot-2

Requirements

Changelog

🆑

  • tweak: Giant spiders drop legs when butchered
  • tweak: Snake meat and spider legs can be cooked on the grill
  • tweak: Snake meat and spider legs can go on skewers, burgers and tacos
  • tweak: All meat cutlets and lingzhi mushrooms can go on skewers

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

RSI Diff Bot; head commit e447e6e merging into 1b992ce
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Consumable/Food/meat.rsi

State Old New Status
snake-cooked Added

Edit: diff updated after e447e6e

@themias
Copy link
Copy Markdown
Contributor Author

themias commented Apr 15, 2026

Looks like this package was marked vulnerable in the last 24 hours:

/home/runner/work/space-station-14/space-station-14/Content.Server.Database/Content.Server.Database.csproj : error NU1901: Warning As Error: Package 'System.Security.Cryptography.Xml' 9.0.0 has a known low severity vulnerability, GHSA-37gx-xxp4-5rgx [/home/runner/work/space-station-14/space-station-14/Content.Server/Content.Server.csproj]

@Princess-Cheeseballs
Copy link
Copy Markdown
Member

Frozen until #43412 is merged

@Princess-Cheeseballs Princess-Cheeseballs added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab. A: Service Area: Service department, including cooking, botany, etc and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some items can't go on kebabs despite having valid sprites for it

3 participants