Skip to content

Conversation

@Absotively
Copy link
Contributor

@Absotively Absotively commented Oct 21, 2025

About the PR

I moved the ChemMaster buffer sort button to the left one button, and made it not a part of the transfer/discard visual grouping.

Why / Balance

The visual grouping of buttons used here is usually used in places where the grouped buttons affect the same thing, especially when they are mutually exclusive. Grouping the transfer and discard buttons helps communicate to players that they are mutually exclusive settings that affect the same thing, i.e. what the ChemMaster does when you use the buttons for specific reagents.

Having the sort button in the same grouping, in between the transfer and discard buttons makes the relationship between the transfer and discard buttons much less clear.

I am aware that there are many other issues with the ChemMaster UI, and that there are active discussions about what to do about it, which may result in changes that make this irrelevant. But this is by far the most confusing part of the current UI in my opinion, and making it less confusing doesn't require much in the way of change, so I decided to PR it while it was on my mind in hopes the ChemMaster could be a touch less confusing while the big decision making is still in progress.

Technical details

Moved the sort button, changed the sort button to use the default button shape, and added a control for padding. All in xaml.

Media

Before:
image

After:
image

Requirements

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XS Denotes a PR that changes 0-9 lines. Changes: UI Changes: Might require knowledge of UI design or code. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Oct 21, 2025
@FairlySadPanda FairlySadPanda added P1: High Priority: Higher priority than other items, but isn't an emergency. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. A: Medical Area: Medical department, including Chemistry and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Oct 21, 2025
@slarticodefast slarticodefast added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. and removed P1: High Priority: Higher priority than other items, but isn't an emergency. labels Oct 21, 2025
@slarticodefast
Copy link
Member

I'm lowering priority on this since it's just a UI improvement rather than an important bugfix.

@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Oct 21, 2025
@Absotively Absotively requested a review from PJB3005 October 21, 2025 22:42
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Oct 21, 2025
@PJBot PJBot added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Oct 21, 2025
@PJB3005 PJB3005 added this pull request to the merge queue Oct 21, 2025
Merged via the queue into space-wizards:master with commit ad2e70f Oct 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Medical Area: Medical department, including Chemistry Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: UI Changes: Might require knowledge of UI design or code. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XS Denotes a PR that changes 0-9 lines. T: New Feature Type: New feature or content, or extending existing content T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants