Move ChemMaster buffer sort button out of transfer/discard button group #41018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
I moved the ChemMaster buffer sort button to the left one button, and made it not a part of the transfer/discard visual grouping.
Why / Balance
The visual grouping of buttons used here is usually used in places where the grouped buttons affect the same thing, especially when they are mutually exclusive. Grouping the transfer and discard buttons helps communicate to players that they are mutually exclusive settings that affect the same thing, i.e. what the ChemMaster does when you use the buttons for specific reagents.
Having the sort button in the same grouping, in between the transfer and discard buttons makes the relationship between the transfer and discard buttons much less clear.
I am aware that there are many other issues with the ChemMaster UI, and that there are active discussions about what to do about it, which may result in changes that make this irrelevant. But this is by far the most confusing part of the current UI in my opinion, and making it less confusing doesn't require much in the way of change, so I decided to PR it while it was on my mind in hopes the ChemMaster could be a touch less confusing while the big decision making is still in progress.
Technical details
Moved the sort button, changed the sort button to use the default button shape, and added a control for padding. All in xaml.
Media
Before:

After:

Requirements