Skip to content

Fix Being Drunk! #41002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2025
Merged

Fix Being Drunk! #41002

merged 6 commits into from
Oct 21, 2025

Conversation

@Princess-Cheeseballs
Copy link
Member

@Princess-Cheeseballs Princess-Cheeseballs commented Oct 20, 2025 •
edited
Loading

About the PR

Allows players to get drunk once again.
Prevents players from vomiting excessively.

Why / Balance

Unintended behavior change.

Technical details

So this required a few things.

  • Firstly, client wasn't applying status effects properly if they were applied on the server. This fixes that.
  • Second, booze power was being divided by 10 due to the liver reducing the metabolic rate of alcohol by 10, so it had to be adjusted to compensate.
  • Third, Metabolism wasn't accounting for randomless properly so random effects would always happen meaning being drunk would just make you vomit a fuckton
  • Fourth, properly documented some magic numbers and adjusted one.
  • Fifth, made it so status effect entity effects don't use StatusEffectContainerComponent since that's added by status effects themselves.
  • Lastly, removed some unused variables, and did some minor cleanup of a few methods.

Media

Requirements

Breaking changes

Changelog

🆑

  • fix: You can now get drunk again.

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. labels Oct 20, 2025
@Princess-Cheeseballs Princess-Cheeseballs added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Oct 20, 2025
@Princess-Cheeseballs
Copy link
Member Author

oh right hashcodes got changed...

@Princess-Cheeseballs
Copy link
Member Author

Tests have broken and I must cry.

@Alpha-Two Alpha-Two added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. and removed P3: Standard Priority: Default priority for repository items. labels Oct 20, 2025
@Alpha-Two
Copy link
Contributor

Raised to P2 as this is a "bugs and exploits that are common and have a moderate impact on the game"

SlamBamActionman
SlamBamActionman approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@SlamBamActionman SlamBamActionman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing anything out of place. Left a single comment but I don't think it's any major issue, so merge once you've read it.

@Princess-Cheeseballs
Copy link
Member Author

merging so slarti can bugfix status effects proper.

@Princess-Cheeseballs Princess-Cheeseballs added this pull request to the merge queue Oct 21, 2025
Merged via the queue into space-wizards:master with commit 4aac3db Oct 21, 2025
10 checks passed
@ThatGuyUSA
Copy link
Contributor

Hell yea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SlamBamActionman SlamBamActionman SlamBamActionman approved these changes

@sowelipililimute sowelipililimute Awaiting requested review from sowelipililimute sowelipililimute is a code owner

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees

No one assigned

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Princess-Cheeseballs @Alpha-Two @ThatGuyUSA @SlamBamActionman @PJBot