Skip to content

Improve CreateDeleteCreateTest failure messages #40996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve CreateDeleteCreateTest failure messages #40996

wants to merge 2 commits into from

Conversation

ElectroJr
Copy link
Member

@ElectroJr ElectroJr commented Oct 20, 2025 •
edited
Loading

About the PR

There is a heisentest where CreateDeleteCreateTest randomly fails the clientCharacters[1].MemberwiseEquals(profile) assert (see #40457). This PR reworks the test to try make the actual failure a bit clearer, so that it should return information about the actual part of the character profile that is not equal.

Even if the source of the bug is fix, IMO this is still worth merging.

Requirements

@ElectroJr ElectroJr added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. A: Integration Tests Area: Integration tests, adding or fixing them labels Oct 20, 2025
@PJBot PJBot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. labels Oct 20, 2025
@ElectroJr ElectroJr mentioned this pull request Oct 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A: Integration Tests Area: Integration tests, adding or fixing them D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ElectroJr @PJBot