Skip to content

optimise shuttle collision entity throwing #40984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

optimise shuttle collision entity throwing #40984

wants to merge 3 commits into from
+36 −13

Conversation

Ilya246
Copy link
Contributor

@Ilya246 Ilya246 commented Oct 19, 2025

About the PR

i should've probably done this right away but now it only throws dynamic entities

Why / Balance

unlag

Technical details

code reused from ExplosionSystem because i couldn't find a better way to do this since from what i'm seeing RT doesn't let you just query dynamic entities on a grid
should probably eventually be made better with engine update

Media

image

successfully threw things here and in other tests
recreation of The Incident:tm: here seems to have lagged way less than without this tweak

Requirements

Changelog

🆑

  • fix: Large grid shuttle collisions should now be somewhat less laggy.

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. labels Oct 19, 2025
Princess-Cheeseballs
Princess-Cheeseballs requested changes Oct 19, 2025
View reviewed changes
@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Oct 19, 2025
@Princess-Cheeseballs Princess-Cheeseballs self-assigned this Oct 19, 2025
Princess-Cheeseballs
Princess-Cheeseballs approved these changes Oct 19, 2025
View reviewed changes
Copy link
Member

@Princess-Cheeseballs Princess-Cheeseballs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly addressing the reviews. Now for the part where we wait for a second maintainer to touch anything related to physics code.

@PJBot PJBot added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Oct 19, 2025
@FairlySadPanda FairlySadPanda added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D2: Medium Difficulty: A good amount of codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Princess-Cheeseballs Princess-Cheeseballs Princess-Cheeseballs approved these changes

@metalgearsloth metalgearsloth Awaiting requested review from metalgearsloth metalgearsloth is a code owner

Assignees

@Princess-Cheeseballs Princess-Cheeseballs

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Awaiting Changes Status: Changes are required before another review can happen size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ilya246 @Princess-Cheeseballs @FairlySadPanda @PJBot