Skip to content

Prevent freindly fauna node from spawning hostile mobs #40979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2025
Merged

Prevent freindly fauna node from spawning hostile mobs #40979

merged 4 commits into from
Oct 21, 2025
+29 −8

Conversation

@quasr-9
Copy link
Contributor

@quasr-9 quasr-9 commented Oct 19, 2025 •
edited
Loading

About the PR

Commented out all the hostile mobs from the friendly fauna artifact node. However, it was floated that the "friendliness" of the fauna was an in-universe lie. If that is the case, the removed spawns can be rolled back, and the description updated to Create 'friendly' fauna, in order to make the falsity of that statement more readily apparent.

Why / Balance

Closes #40965

Technical details

yaml only

Media

n/a

Requirements

Breaking changes

Changelog

🆑 Quasr

  • tweak: The "Friendly Fauna" artifact node no longer spawns hostile mobs

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Oct 19, 2025
slarticodefast
slarticodefast requested changes Oct 19, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't comment them out, either remove the lines completely or move them to a new hostile fauna node.

@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Oct 19, 2025
@slarticodefast slarticodefast added T: Cleanup Type: Code clean-up, without being a full refactor or feature A: Science Area: Science department, not including Silicons. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Oct 19, 2025
@PJBot PJBot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Oct 19, 2025
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Oct 19, 2025
@Jocentrik
Copy link

This would make that node so much better 😭 🙏

@PicklOH
Copy link
Contributor

PicklOH commented Oct 20, 2025

Add a new node that does use 'friendly' and only contains hostile mobs :godo:

@quasr-9
Copy link
Contributor Author

quasr-9 commented Oct 21, 2025

Add a new node that does use 'friendly' and only contains hostile mobs :godo:

Probably outside the scope of this PR, but I’ll see what I can do.

@PJBot PJBot added size/S Denotes a PR that changes 10-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Oct 21, 2025
slarticodefast
slarticodefast approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes to move them into a separate hostile fauna node instead of just removing them.
Thank you for your contribution!

@PJBot PJBot added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Oct 21, 2025
@slarticodefast slarticodefast removed the S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. label Oct 21, 2025
@slarticodefast slarticodefast added this pull request to the merge queue Oct 21, 2025
Merged via the queue into space-wizards:master with commit 479e5f6 Oct 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

No one assigned

Labels

A: Science Area: Science department, not including Silicons. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"friendly fauna" node does NOT spawn only friendly fauna

5 participants

@quasr-9 @Jocentrik @PicklOH @slarticodefast @PJBot