Update Space Villain's UI #40963
Open
Update Space Villain's UI #40963
+177
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJBot
added
S: Untriaged
2 tasks
|
This should probably just be converted to use xaml instead of defining every single element of the UI in C#. |
PJBot
added
size/M
|
@slarticodefast Rewrote the menu using XAML! It seems to work; please let me know if I should do something differently! |
|
I'll merge #40962 into this so that I can localize all strings. |
Potentially breaking: All strings related to Space Villain now share the `space-villain` prefix, instead of mixing `spacevillain` and `space-villain`.
|
Localized and made a few more tweaks! |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
S: Merge Conflict
github-actions
bot
removed
the
S: Merge Conflict
|
Is it me or is the notification button for this issue exceptionally broken for everyone, opening a diff between two random commits...? GitHub what are you doing?! 😆 |
FairlySadPanda
added
P3: Standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
I attempted to improve the UI of the Space Villain arcade machine.
Why / Balance
I wanted to experiment a bit with SS14's layout code, and figured I could try doing something useful as well.
Without this PR, some of Space Villain's messages are too long to be displayed in the game's window, and end up being clipped, looking kinda weird and unpolished as a result.
The window's rescaling functionality also was strange, so I attempted to address that by making the new layout fill any window size it's given, while making sure that the Attack / Heal / Recharge buttons do not change position during gameplay.
Technical details
Made a lot of use of
GridContainers andHorizontalExpandandHAlignment.Stretch.Used
BoxContaineras spacers to shift messages to the middle of the window and buttons to the bottom.Split the fighter info label into two separate HP and MP labels so that they could be colored appropriately.
Made use of Fluent's functionality (functions, terms, replacements) to improve the localization support of the minigame.
Media
2025-10-19.18-39-43.mp4
Requirements
Breaking changes
For consistency, all
spacevillain-*localization keys were changed tospace-villain-*.Changelog
🆑