Skip to content

Conversation

Hitlinemoss
Copy link
Contributor

@Hitlinemoss Hitlinemoss commented Oct 18, 2025

About the PR

The following containers have been changed:

  • beer growler (reduced; 150u -> 100u)
  • coconut water jug (reduced; 300u -> 150u)
  • coffee jug (reduced; 300u -> 150u)
  • Dr. Gibb jug (reduced; 300u -> 100u)
  • green tea jug (reduced; 300u -> 150u)
  • ice bucket (reduced; 200u -> 150u)
  • ice jug (removed entirely)
  • iced tea jug (reduced; 300u -> 150u) [this jug only shows up mapped on one shuttle, anyway, could probably stand to be removed]
  • Magnum-Ale growler (reduced; 150u -> 100u)
  • mead jug (removed entirely)- root beer jug (reduced; 300u -> 100u)
  • root beer jug (reduced; 300u -> 100u)
  • Smite jug (reduced; 300u -> 100u)
  • sugar jug (reduced; 300u -> 150u)
  • tea jug (reduced; 300u -> 150u)
  • watermelon juice jug (reduced; 300u -> 150u)

Other changes:

  • Absinthe, blue curacao, grenadine, and melon liquor now spawn in the dispensers roundstart.
  • Mead no longer spawns in the booze dispenser roundstart.
  • Ice buckets are now 2x2, they can be inserted into the dispensers as a container (rather than as a glass), and are labelled "ice" by default; the ice bucket replaces the old ice jug.

Why / Balance

  • Some of these containers held 300u in a 2x2 space, which is (to my knowledge) the largest volume of any 2x2 container (larger than a bucket). It's weird for the beverage jugs used to hold watermelon juice or sugar to be twice as big as standard beverage jugs for no real reason. I've standardized all "jug"-type containers to hold 150u, and all "bottle"-type containers (i.e stuff people might want to directly drink from, including jugs that are eventually planned to be resprited into bottles, e.g the root beer and Smite jugs) to hold 100u.
  • The ice jug specifically was removed outright because the ice bucket can fill the same role.
  • The mead jug specifically was removed outright because mead is a simple drink to mix (just sugar and universal enzyme), it doesn't have parity with the other bar liquors (which generally can't be hand-mixed, but are available in the Booze-o-Mat), and it's really not even a popular order anyway
  • Absinthe, blue curacao, grenadine, and melon liquor are common bar ingredients, but they're buried deep in the (honestly pretty bloated) Booze-o-Mat inventory, so now they spawn in the dispensers roundstart.

I have other bar-related changes in mind for future PRs but I think these container changes are probably a good starting point before I work on other stuff (e.g adjusting the contents of the booze-o-mat).

Technical details

YAML changes.

Media

moss-barorganization

Requirements

Breaking changes

  • DrinkIceJug has been removed (migrated to DrinkIcebucket).
  • DrinkMeadJug has been removed (migrated to null).

Changelog

🆑

  • add: Absinthe, blue curacao, grenadine, and melon liquor now spawn in bar dispensers by default.
  • remove: Mead no longer spawns in the booze dispenser by default.
  • tweak: Ice buckets can now be inserted into bar dispensers as containers, rather than as glasses.
  • tweal: Ice buckets are now a 2x2 item (rather than 1x2).
  • tweak: Most dispenser containers have been resized to hold less volume.

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Oct 18, 2025
@Princess-Cheeseballs
Copy link
Member

No!!! My powergaming!!!

Copy link
Member

@Princess-Cheeseballs Princess-Cheeseballs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't be overriding the volume sizes of their parents, and if they have to then they should get new parents.

@Hitlinemoss
Copy link
Contributor Author

Prototype parenting has been cleaned up. The ice bucket still has a few overrides, but that's a special case since that's parenting directly from DrinkBase / DrinkBaseMaterialMetal rather than from any children of those.

@Hitlinemoss Hitlinemoss changed the title Resized most booze/soda dispenser containers + other minor touchups Adjusted volume of most booze/soda dispenser containers + other minor touchups Oct 18, 2025
@IamVelcroboy
Copy link
Contributor

Why are some 100 and others 150? Why not just make jugs consistent despite their contents?

@Hitlinemoss
Copy link
Contributor Author

Why are some 100 and others 150? Why not just make jugs consistent despite their contents?

The 100u containers aren't jugs, they're bottles (e.g the Space Cola bottle), or placeholder jugs that are intended to be replaced with bottles in the future.

@Princess-Cheeseballs
Copy link
Member

The 100u containers aren't jugs, they're bottles (e.g the Space Cola bottle), or placeholder jugs that are intended to be replaced with bottles in the future.

Honestly I don't think there should be a difference tbqh other than sprite. I'd choose one or the other, and I'm fine with 150u for both since jugs are 200u.

@Hitlinemoss
Copy link
Contributor Author

The 100u containers aren't jugs, they're bottles (e.g the Space Cola bottle), or placeholder jugs that are intended to be replaced with bottles in the future.

Honestly I don't think there should be a difference tbqh other than sprite. I'd choose one or the other, and I'm fine with 150u for both since jugs are 200u.

Beverage jugs are 150u, not 200u. Also the 100u bottles aren't just used for the beverage dispenser, they're the kind of good-sized soda bottles that you might see someone drink from directly (e.g a Space Cola bottle spawns in the Happy Honk meal) which is the main reason I didn't want to just bump them all up to 150u.

@Princess-Cheeseballs
Copy link
Member

Beverage jugs are 150u, not 200u.

Was talking about chemical jugs

Also the 100u bottles aren't just used for the beverage dispenser, they're the kind of good-sized soda bottles that you might see someone drink from directly (e.g a Space Cola bottle spawns in the Happy Honk meal) which is the main reason I didn't want to just bump them all up to 150u.

If we're going by liters I think the conversion would have a 2 liter bottle be 120u? I think 150u is fine personally. They can have a little extra soder.

@Hitlinemoss
Copy link
Contributor Author

They can have a little extra soder.

I mean I'm not theoretically opposed to making the bottles bigger (and the soda dispenser a consistent 150u), but unlike stuff like the sugar jug or orange juice XL they see use outside of the dispenser itself and that means it affects stuff other than just the bar. Also all the bottled liquor that can go in the booze dispenser is 100u as well (other thant the beer/ale growlers, which I reduced to 100u in this PR) and it would feel weird to have liquor bottles have less volume than soda bottles.

@EthanQix
Copy link

Silly question, but why not just normalize all beverage jugs to 300u and 3x3 grid size ? They are meant to contain a large amount of liquid, not 5 glasses worth.

@Hitlinemoss
Copy link
Contributor Author

Silly question, but why not just normalize all beverage jugs to 300u and 3x3 grid size ? They are meant to contain a large amount of liquid, not 5 glasses worth.

Internal storage of the dispensers would also need to be reworked to fit the resized jugs. On more of a quality-of-life note, making them 3x3 would hamper your ability to carry them in a bag (a satchel can hold exactly one 3x3 item).

Physical inventory size aside, making jugs too voluminous also means that bartenders never need to actually replace them in normal gameplay. I, for one, have never run out of sugar as bartender even if I'm spending an entire shift just making ice cream. So I think a more modest volume is better since it means bartenders are more likely to need to refill the machines (and that means interaction with other departments, e.g the kitchen / hydropnics / cargo, which is good).

@FairlySadPanda FairlySadPanda added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Oct 21, 2025
@FairlySadPanda FairlySadPanda added T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it A: Service Area: Service department, including cooking, botany, etc labels Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it T: Bugfix Type: Bugs and/or bugfixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants