-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Adjusted volume of most booze/soda dispenser containers + other minor touchups #40956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adjusted volume of most booze/soda dispenser containers + other minor touchups #40956
Conversation
No!!! My powergaming!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These shouldn't be overriding the volume sizes of their parents, and if they have to then they should get new parents.
Prototype parenting has been cleaned up. The ice bucket still has a few overrides, but that's a special case since that's parenting directly from DrinkBase / DrinkBaseMaterialMetal rather than from any children of those. |
Why are some 100 and others 150? Why not just make jugs consistent despite their contents? |
The 100u containers aren't jugs, they're bottles (e.g the Space Cola bottle), or placeholder jugs that are intended to be replaced with bottles in the future. |
Honestly I don't think there should be a difference tbqh other than sprite. I'd choose one or the other, and I'm fine with 150u for both since jugs are 200u. |
Beverage jugs are 150u, not 200u. Also the 100u bottles aren't just used for the beverage dispenser, they're the kind of good-sized soda bottles that you might see someone drink from directly (e.g a Space Cola bottle spawns in the Happy Honk meal) which is the main reason I didn't want to just bump them all up to 150u. |
Was talking about chemical jugs
If we're going by liters I think the conversion would have a 2 liter bottle be 120u? I think 150u is fine personally. They can have a little extra soder. |
I mean I'm not theoretically opposed to making the bottles bigger (and the soda dispenser a consistent 150u), but unlike stuff like the sugar jug or orange juice XL they see use outside of the dispenser itself and that means it affects stuff other than just the bar. Also all the bottled liquor that can go in the booze dispenser is 100u as well (other thant the beer/ale growlers, which I reduced to 100u in this PR) and it would feel weird to have liquor bottles have less volume than soda bottles. |
Silly question, but why not just normalize all beverage jugs to 300u and 3x3 grid size ? They are meant to contain a large amount of liquid, not 5 glasses worth. |
Internal storage of the dispensers would also need to be reworked to fit the resized jugs. On more of a quality-of-life note, making them 3x3 would hamper your ability to carry them in a bag (a satchel can hold exactly one 3x3 item). Physical inventory size aside, making jugs too voluminous also means that bartenders never need to actually replace them in normal gameplay. I, for one, have never run out of sugar as bartender even if I'm spending an entire shift just making ice cream. So I think a more modest volume is better since it means bartenders are more likely to need to refill the machines (and that means interaction with other departments, e.g the kitchen / hydropnics / cargo, which is good). |
About the PR
The following containers have been changed:
Other changes:
Why / Balance
I have other bar-related changes in mind for future PRs but I think these container changes are probably a good starting point before I work on other stuff (e.g adjusting the contents of the booze-o-mat).
Technical details
YAML changes.
Media
Requirements
Breaking changes
Changelog
🆑