Skip to content

Migrate DrinkComponent uses to EdibleComponent #40136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Migrate DrinkComponent uses to EdibleComponent #40136

wants to merge 2 commits into from

Conversation

@IProduceWidgets
Copy link
Contributor

@IProduceWidgets IProduceWidgets commented Sep 5, 2025 •
edited
Loading

About the PR

Swaps out DrinkComp for EdibleComp in all but one instance where it lacks functionality presently.
Curse you spray bottle and your bizzare use case.

Why / Balance

idk it wasn't done when the comp was merged and it annoyed me that this was a blocker on another pr I had.

Technical details

Media

Requirements

Breaking changes

Changelog

shouldn't be any visible change to players except maybe some utensils will work more reliably.

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Sep 5, 2025
@IProduceWidgets
Copy link
Contributor Author

Test fail erroneous?

@slarticodefast
Copy link
Member

slarticodefast commented Sep 5, 2025 •
edited
Loading

Princess and I were planning to merge #39221 first, but I still have to review that one.

@IProduceWidgets
Copy link
Contributor Author

Princess and I were planning to merge #39221 first, but I still have to review that one.

feel free to close when resolved

@iaada iaada added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Cleanup Type: Code clean-up, without being a full refactor or feature A: Service Area: Service department, including cooking, botany, etc and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IProduceWidgets @slarticodefast @PJBot @iaada