-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Edible Verb Fixes #39933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iaada
merged 5 commits into
space-wizards:master
from
Princess-Cheeseballs:you-cant-injest-the
Sep 27, 2025
Merged
Edible Verb Fixes #39933
iaada
merged 5 commits into
space-wizards:master
from
Princess-Cheeseballs:you-cant-injest-the
Sep 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2025
Merged
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
# Conflicts: # Resources/Prototypes/Entities/Objects/Consumable/Drinks/drinks_metamorphic.yml
2 tasks
iaada
approved these changes
Sep 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better version of the bugfix I attempted.
F1restar4
pushed a commit
to F1restar4/space-station-14
that referenced
this pull request
Sep 30, 2025
* You cannot drink the cannot drink * Undo that shit * Whoops * Fix test fails --------- Co-authored-by: Princess Cheeseballs <[email protected]>
|
Does this fix #39816? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A: General Interactions
Area: General in-game interactions that don't relate to another area.
P3: Standard
Priority: Default priority for repository items.
S: Approved
Status: Reviewed and approved by at least one maintainer; a PR may require another approval.
S: Needs Review
Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved.
size/S
Denotes a PR that changes 10-99 lines.
T: Bugfix
Type: Bugs and/or bugfixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixes #40037
Fixes a number of bugs involving the edible system and verb usage/creation.
Namely:
Of note is that a number of drinks still use drink component and therefore do not have a specified utensil (meaning any will work). Until #39221 is merged this will be the case as I'm not going to retroactively add utensil support to a component that is going to be killed (It's also a really non-impactful bug)
Why / Balance
Just a bunch of small fixes.
Technical details
Made it so private IsDigestible method for body system only pops up if the item is actually even possible to eat in the first place.
Made it so utensil system doesn't stop you from ingesting something if it doesn't specify which utensil is okay.
Raised priority of jackboots item slot
Gave BaseDrink a utensil
Media
Requirements
Breaking changes
Changelog