Skip to content

Conversation

@Princess-Cheeseballs
Copy link
Member

@Princess-Cheeseballs Princess-Cheeseballs commented Aug 28, 2025

About the PR

Fixes #40037

Fixes a number of bugs involving the edible system and verb usage/creation.
Namely:

  • You cannot digest the [Item you don't want to eat]
  • You cannot use the knife to ingest the [Literally anything you can't eat]
  • Jackboots now eject knife if you're a moth instead of you trying to eat your shoes.
  • If no utensils are specified you can use any utensil
  • Drinks use spoons instead of forks to be eaten

Of note is that a number of drinks still use drink component and therefore do not have a specified utensil (meaning any will work). Until #39221 is merged this will be the case as I'm not going to retroactively add utensil support to a component that is going to be killed (It's also a really non-impactful bug)

Why / Balance

Just a bunch of small fixes.

Technical details

Made it so private IsDigestible method for body system only pops up if the item is actually even possible to eat in the first place.

Made it so utensil system doesn't stop you from ingesting something if it doesn't specify which utensil is okay.

Raised priority of jackboots item slot

Gave BaseDrink a utensil

Media

Requirements

Breaking changes

Changelog

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. labels Aug 28, 2025
@Princess-Cheeseballs Princess-Cheeseballs added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 28, 2025
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 11, 2025
# Conflicts:
#	Resources/Prototypes/Entities/Objects/Consumable/Drinks/drinks_metamorphic.yml
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 12, 2025
@iaada iaada mentioned this pull request Sep 27, 2025
2 tasks
Copy link
Member

@iaada iaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better version of the bugfix I attempted.

@iaada iaada added this pull request to the merge queue Sep 27, 2025
Merged via the queue into space-wizards:master with commit d817286 Sep 27, 2025
10 checks passed
F1restar4 pushed a commit to F1restar4/space-station-14 that referenced this pull request Sep 30, 2025
* You cannot drink the cannot drink

* Undo that shit

* Whoops

* Fix test fails

---------

Co-authored-by: Princess Cheeseballs <[email protected]>
@Coolsurf6
Copy link
Contributor

Does this fix #39816?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

You can drink a bottle of water with a fork

4 participants