fix repeated scale visuals removal/ensuring #39432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJBot
added
S: Untriaged
ScarKy0
approved these changes
Aug 6, 2025
slarticodefast
added
A: Core Tech
FairlySadPanda
pushed a commit
to FairlySadPanda/honk-station-15
that referenced
this pull request
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Small bug I found with
ScaleVisualsComponent.Needed for #34002
Why / Balance
bugfix
Technical details
When transforming from a human into a dwarf the component is first added, and setting the appearance data adjusts the
SpriteComponentaccordingly inOnAppearanceChanged. When transforming back into a human the component is removed, and the scale in theSpriteComponentreset without deleting the now unused appearance data. When adding the component again with the same settings, thenAppearanceChangedEventis not raised since the appearance data remains the same. To fix this we properly clear the appearance data when the component is removed.Requirements
Breaking changes
none
Changelog
nope