convert dwarfs to use ScaleVisualsComponent #39422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Converts dwarfs to use
ScaleVisualsComponentwhich sets the sprite scale according to its appearance data instead of having the scale hardcoded into theSpriteComponent.This allows us to change their size for all players from the server, instead of only for the local client, which is needed for changeling transforms.
Why / Balance
AppearanceSystem compliance.
Needed for #34002
Technical details
Replace the component.
ScaleVisualsComponentsets the same datafield in theSpriteComponent, so the result is the same.noRotanddrawDepthwere removed because those were already inherited fromBaseMob.Media
Dwarfs are still dwarf-sized

Requirements
Breaking changes
none
Changelog
not player facing