Skip to content

Conversation

@slarticodefast
Copy link
Member

About the PR

Converts dwarfs to use ScaleVisualsComponent which sets the sprite scale according to its appearance data instead of having the scale hardcoded into the SpriteComponent.
This allows us to change their size for all players from the server, instead of only for the local client, which is needed for changeling transforms.

Why / Balance

AppearanceSystem compliance.
Needed for #34002

Technical details

Replace the component. ScaleVisualsComponent sets the same datafield in the SpriteComponent, so the result is the same.
noRot and drawDepth were removed because those were already inherited from BaseMob.

Media

Dwarfs are still dwarf-sized
grafik

grafik

Requirements

Breaking changes

none

Changelog
not player facing

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XS Denotes a PR that changes 0-9 lines. labels Aug 6, 2025
@FairlySadPanda FairlySadPanda added A: Character/Species Area: Player characters and species features and content. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 6, 2025
Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna scale entire vulture to be wide.

@ScarKy0 ScarKy0 merged commit 8ef212a into space-wizards:master Aug 6, 2025
11 checks passed
@perryprog
Copy link
Contributor

perryprog commented Aug 6, 2025

Gonna scale entire vulture to be wide.

Probably a better way to do this, but enjoy.

entities emplace { var $value scale:get first * [2,1] => $new; var $value scale:set { val Vector2 $new } first }

(Pairs well with /zoom 2 1.)

@slarticodefast slarticodefast deleted the cleanup-dwarf-scale branch August 7, 2025 02:33
FairlySadPanda pushed a commit to FairlySadPanda/honk-station-15 that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Character/Species Area: Player characters and species features and content. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XS Denotes a PR that changes 0-9 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants