fix: make IdentityComp.IdentityEntitySlot optional #39357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJBot
added
S: Untriaged
perryprog
added
T: Bugfix
perryprog
commented
Aug 3, 2025
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
slarticodefast
approved these changes
Oct 21, 2025
PJBot
added
the
S: Approved
github-actions
bot
removed
the
S: Merge Conflict
|
Aaaaaah, those Heisentests 😠 |
Merged
via the queue into
space-wizards:master
with commit Oct 21, 2025
5a0a984
13 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This fixes a rare edge case where if the client handles some event that depends on identity in response to that entity's spawning it would end up dying to a NRE.
Why / Balance
Bugs bad.
Technical details
IdentityEntitySlotis ensured on ComponentInit, so it's possible to have stuff that depends on identity occur while the IdentityComponent is still in its Added lifestage. This changes the nullability of the slot to accurately represent that.This does mean there's an extreme edge case where Identity.Name/Entity can return the real identity buuuuuut I feel like that's probably fine. (As far as I know this could only really happen on an entity entering a client's PVS for the first time.)
Media
Identity still works
Requirements
Breaking changes
IdentityComponent.IdentityEntitySlotis now optional.Changelog
wawaa