-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add examinable clothing #39263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add examinable clothing #39263
Conversation
f111748
to
933bf19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i also suggest moving all ftl related files to one folder so it won't be as messy
abstract: true | ||
id: BaseExaminableClothing | ||
components: | ||
- type: ExaminableClothing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now this prototype is useless
you are adding the component anyway to write a special examine
so what i suggest
- add to the cs file a default examine like "They are wearing item"
- remove this prototype at all to reduce unnecessary parenting, because it's just one component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and i also don't like all these strings being hardcoded
I don't really like the handling of how the pride item are included in the examine. They're just pride-themed pieces of clothing, and I don't really think it makes sense to bloat the examine text on 1-out-of-every-5th person you examine with really eye-catching multicolored text for items that don't hold any actual significance. Especially considering that colored text isn't even used like this in any other place in the game. |
for context as the original implementer in imp (impstation#2462) we've been playing with these changes for some time, and this has never been an aesthetic eyesore. the changes were initially implemented to improve visibility on pride items, and were later used for a specific item related to player comfort levels (impstation#2626). if anything, it has led to more people wanting to use and carry items like these to rep their character's and personal pride, knowing that others will see them, which i think is a net positive -- it reinforces why pride items exist in SS14 to begin with. i do apologize in advance, i am not well-versed on upstream sensibilities so please understand that these comments of mine only pertain to my implementation and how the changes have been perceived by our community. |
Do the pride description colors have toggles for accessibility? Otherwise, great feature 👍 |
They do not as-is but that wouldn't be the hardest feature in the world to implement |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the PR
Adds the ability for clothing to be marked as examinable, which results in it being indicated textually on examining the wearer. Also scaffolds examine inventory relay events, which could be used for e.g. examinable internals state on other people later down the line.
Why / Balance
This is a middle point between the current "only hands" examination and ss13-style "everything" examination, allowing specific pieces of clothing to be marked as examinable, optionally with a unique string. Currently, this is used to flag:
Technical details
ExaminedEvent
as an inventory relay eventExaminableClothingComponent
/ExaminableClothingSystem
to handle theExaminedEvent
Media
Requirements
Pride examine texts authored by & used with permission from @jtfg-dev, originally part of aer work on Impstation.
Changelog
🆑