Skip to content

Conversation

sowelipililimute
Copy link
Member

About the PR

Adds the ability for clothing to be marked as examinable, which results in it being indicated textually on examining the wearer. Also scaffolds examine inventory relay events, which could be used for e.g. examinable internals state on other people later down the line.

Why / Balance

This is a middle point between the current "only hands" examination and ss13-style "everything" examination, allowing specific pieces of clothing to be marked as examinable, optionally with a unique string. Currently, this is used to flag:

  • pride items
  • medals
  • lawyer's badge

Technical details

  • set up ExaminedEvent as an inventory relay event
  • ExaminableClothingComponent/ExaminableClothingSystem to handle the ExaminedEvent

Media

grafik grafik grafik grafik

Requirements

Pride examine texts authored by & used with permission from @jtfg-dev, originally part of aer work on Impstation.

Changelog
🆑

  • add: Medals, pride pins and scarves, and lawyer badges are now visible on examination

@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 28, 2025
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Jul 28, 2025
@sowelipililimute sowelipililimute added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces A: Accessibility Area: Accessibility settings and features. A: Roleplay/Lore Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 28, 2025
@PJBot PJBot removed the size/M Denotes a PR that changes 100-999 lines. label Jul 28, 2025
Copy link
Contributor

@lzk228 lzk228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also suggest moving all ftl related files to one folder so it won't be as messy

abstract: true
id: BaseExaminableClothing
components:
- type: ExaminableClothing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now this prototype is useless
you are adding the component anyway to write a special examine
so what i suggest

  1. add to the cs file a default examine like "They are wearing item"
  2. remove this prototype at all to reduce unnecessary parenting, because it's just one component

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i also don't like all these strings being hardcoded

@Flareguy
Copy link
Contributor

I don't really like the handling of how the pride item are included in the examine. They're just pride-themed pieces of clothing, and I don't really think it makes sense to bloat the examine text on 1-out-of-every-5th person you examine with really eye-catching multicolored text for items that don't hold any actual significance. Especially considering that colored text isn't even used like this in any other place in the game.

@jtfg-dev
Copy link

for context as the original implementer in imp (impstation#2462)

we've been playing with these changes for some time, and this has never been an aesthetic eyesore. the changes were initially implemented to improve visibility on pride items, and were later used for a specific item related to player comfort levels (impstation#2626). if anything, it has led to more people wanting to use and carry items like these to rep their character's and personal pride, knowing that others will see them, which i think is a net positive -- it reinforces why pride items exist in SS14 to begin with.

i do apologize in advance, i am not well-versed on upstream sensibilities so please understand that these comments of mine only pertain to my implementation and how the changes have been perceived by our community.

@arenaconspiracy
Copy link

Do the pride description colors have toggles for accessibility? Otherwise, great feature 👍

@jtfg-dev
Copy link

They do not as-is but that wouldn't be the hardest feature in the world to implement

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 6, 2025
Copy link
Contributor

github-actions bot commented Aug 6, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Accessibility Area: Accessibility settings and features. A: Roleplay/Lore Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants