Skip to content

rolebriefingcomponent bugfix #39261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

rolebriefingcomponent bugfix #39261

merged 1 commit into from
Jul 28, 2025
+2 −2

Conversation

xsainteer
Copy link
Contributor

@xsainteer xsainteer commented Jul 28, 2025 •
edited
Loading

About the PR

RoleBriefingComponent is attached to a mind, the same mind getting "made traitor" by MakeTraitor method does not lead to an error after my fix

Why / Balance

Technical details

before my bugfix there was AddComp, which does not check if the component already is here. I changed it to EnsureComp

Media

Before:

2025-07-28.18-25-23.mp4

log:

System.InvalidOperationException: Component reference type RoleBriefing already occupied by Content.Server.Roles.RoleBriefingComponent
   at Robust.Shared.GameObjects.EntityManager.AddComponentInternal[T](EntityUid uid, T component, ComponentRegistration reg, Boolean overwrite, Boolean skipInit, MetaDataComponent metadata)
   at Robust.Shared.GameObjects.EntityManager.AddComponent[T](EntityUid uid)
   at Content.Server.GameTicking.Rules.TraitorRuleSystem.MakeTraitor(EntityUid traitor, TraitorRuleComponent component) in TraitorRuleSystem.cs:line 128

After:

2025-07-28.18-29-08.mp4

Requirements

Breaking changes

Changelog

@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 28, 2025
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 28, 2025
slarticodefast
slarticodefast approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bugfix!

@PJBot PJBot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 28, 2025
@slarticodefast slarticodefast merged commit 3c76b5a into space-wizards:master Jul 28, 2025
12 checks passed
@xsainteer xsainteer deleted the rolebriefing-bugfix branch July 28, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

No one assigned

Labels

S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xsainteer @slarticodefast @PJBot